Ensure udev rules works if devices changed since creation #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deleted the
kyyalama2
pushed a commit
that referenced
this pull request
May 24, 2022
* Ensure udev rules works if devices changed since creation (#533) * Add option to allow others instead of group in udev rules (#534) Co-authored-by: xlz-jgoutin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version, udev rules are generated with hardcoded KERNEL udev entries for PCI devices that were found when the sdk_setup.sh script is run.
But, if the number of FPGA change, the udev rule is not updated without re-run the script.
This can be an issue if building an AMI on an instance with a single FPGA (or even no FPGA) and then using the AMI to start an instance type with more FPGA devices.
So, the udev rule was changed to dynamically detect devices independently to the initial configuration.