chore: remove TSLint #8946
Merged
chore: remove TSLint #8946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
force-pushed
the
huijbers/remove-tslint
branch
2 times, most recently
from
bf9cf10
to
29e7895
Compare
On every build, we are basically compiling our code 3 times: once with jsii, once with eslint and once with tslint. Also, you need 2 plugins installed into your IDE to get linter erroring and fixing as you type. Between these, TSLint is deprecated, so why are we even doing this anymore? Reduce build times by removing TSLint and migrating all the rules we were getting from it to ESLint. Make all packages lint correctly, which was also not the case.
rix0rrr
force-pushed
the
huijbers/remove-tslint
branch
from
29e7895
to
6b82c89
Compare
rix0rrr
added a commit
that referenced
this pull request
Jul 9, 2020
Introduce a `canonicalizeTemplate` function in `@aws-cdk/assert` which translates templates to a common form w.r.t. asset hashes. Use this in some tests and in `cdk-integ-assert` to make the tests succeed if all that is different is the specific asset hash. Currently only supports legacy assets, should be updated for new-style assets when we switch to those. This change is necessary to unblock other build improvements/changes such as #8946.
rix0rrr
added a commit
that referenced
this pull request
Jul 9, 2020
Introduce a `canonicalizeTemplate` function in `@aws-cdk/assert` which translates templates to a common form w.r.t. asset hashes. Use this in some tests and in `cdk-integ-assert` to make the tests succeed if all that is different is the specific asset hash. Currently only supports legacy assets, should be updated for new-style assets when we switch to those. This change is necessary to unblock other build improvements/changes such as #8946.
mergify bot
pushed a commit
that referenced
this pull request
Jul 9, 2020
Introduce a `canonicalizeTemplate` function in `@aws-cdk/assert` which translates templates to a common form w.r.t. asset hashes. Use this in some tests and in `cdk-integ-assert` to make the tests succeed if all that is different is the specific asset hash. It is switched on by putting `/// !cdk-integ pragma:ignore-assets` at the top of the integ test file. Currently only supports legacy assets, should be updated for new-style assets when we switch to those. This change is necessary to unblock other build improvements/changes such as #8946. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
RomainMuller
approved these changes
Jul 10, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On every build, we are basically compiling our code 3 times: once with
jsii, once with eslint and once with tslint.
Between these, TSLint is deprecated, so why are we even doing this
anymore? Reduce build times by removing TSLint and migrating all the
rules we were getting from it to ESLint.
Also, with the current setup you need 2 plugins installed into your
IDE to get all linting errors reported as-you-type. Reduce to one
plugin.
This change makes
lerna run lintrun successfully, which was also not the case.This change shaves 5 minutes (25%) off of the PR build (21 minutes down to 16 minutes).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license