Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(awslint): publish as an external module #8558

Merged
merged 5 commits into from
Jun 19, 2020
Merged

feat(awslint): publish as an external module #8558

merged 5 commits into from
Jun 19, 2020

Conversation

workeitel
Copy link
Contributor

@workeitel workeitel commented Jun 15, 2020 •
edited by SomayaB
Loading

awslint is a very helpful tool for writing CDK constructs. There are
still some assumptions about the current mono-repo in the tool but
nothing problematic and it can be addressed afterwards.

This commit is only moving the tool into another folder to include it into the publish to npm.

Closes #1942

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@workeitel
feat(awslint) Make it consumable by other projects
189addd 
awslint is a very helpful tool for writing CDK constructs. There are
still some assumptions about the current mono-repo in the tool but
nothing problematic and it can be addressed afterwards.

aws#1942
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 189addd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb changed the title feat(awslint): Make it consumable by other projects feat(awslint): publish as an external module Jun 16, 2020
eladb
eladb previously requested changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we will need to also switch the private to true in package.json, and also verify that after running yarn run pack from the root, the resulting dist directory contains this module.

@mergify mergify bot dismissed eladb’s stale review June 16, 2020 23:06

Pull request has been modified.

@workeitel
Copy link
Contributor Author

Thanks @eladb for the quick review! I confirmed the file exist:

$ ls -1 dist/js/awslint-0.0.0.tgz
dist/js/awslint-0.0.0.tgz

The package command was missing as well: c123018

I'm not sure if that's the right approach. But using cdk-package does not work since cdk-build-tools depends on awslint and I would introduce a chicken-egg problem.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c123018
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@workeitel
Copy link
Contributor Author

@eladb It looks like the linter fails because I named it a feature and ##[error]Features must contain a change to a test file - should I change the title of the commit? I guess changing a test file would not provide much benefit here?

@eladb eladb added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-readme The PR linter will not require README changes labels Jun 18, 2020
eladb
eladb previously approved these changes Jun 18, 2020
View reviewed changes
@eladb
Copy link
Contributor

eladb commented Jun 18, 2020

Added exemption labels

@mergify mergify bot dismissed eladb’s stale review June 18, 2020 22:22

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b1f1851
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a4e1a76
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 378939c into aws:master Jun 19, 2020
@Chriscbr Chriscbr mentioned this pull request Aug 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make awslint publicly available
3 participants
@workeitel @aws-cdk-automation @eladb