chore: upgrade NuGet options to 256x256 icon #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NuGet detail pages render logos in 128x128 size, so using a 64x64 image would have resulted in a bully finish. Additionally, support for HiDPI displays may require using assets with double the pixels, hence using a 256x256 icon instead.
RomainMuller
requested review from
eladb,
garnaat,
nija-at,
rix0rrr,
shivlaks,
skinny85 and
SoManyHs
as code owners
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
rix0rrr
approved these changes
Sep 19, 2019
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
pushed a commit
that referenced
this pull request
Sep 23, 2019
The NuGet detail pages render logos in 128x128 size, so using a 64x64 image would have resulted in a bully finish. Additionally, support for HiDPI displays may require using assets with double the pixels, hence using a 256x256 icon instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NuGet detail pages render logos in 128x128 size, so using a 64x64
image would have resulted in a bully finish. Additionally, support for
HiDPI displays may require using assets with double the pixels, hence
using a 256x256 icon instead.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license