feat(synthetics): cleanup provisioned lambda and layers for canary #32738
Conversation
github-actions
bot
added
p2
distinguished-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32738 +/- ##
=======================================
Coverage 81.39% 81.39%
=======================================
Files 225 225
Lines 13714 13714
Branches 2411 2411
=======================================
Hits 11162 11162
Misses 2277 2277
Partials 275 275
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-community-review
There was a problem hiding this comment.
Can you please update the Deleting underlying resources on canary deletion paragraph with a description of the new attribute?
There was a problem hiding this comment.
Oh.. I've forgotten to update the readme. Thanks!
| @@ -70,6 +70,8 @@ export enum Cleanup { | |||
| * Clean up the underlying Lambda function only. The user is | |||
| * responsible for cleaning up all other resources left behind | |||
| * by the Canary. | |||
| * | |||
| * @deprecated use provisionedResourceCleanup | |||
There was a problem hiding this comment.
I guess we should deprecate the cleanup property instead 🤔
There was a problem hiding this comment.
I've made cleanup deprecated.
aws-cdk-automation
removed
the
pr/needs-community-review
|
@lpizzinidev Thank you for your review! I've addressed your comments. |
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
|
||
| const app = new App(); | ||
|
|
||
| new IntegTest(app, 'SyntheticsCanaryProvisionedResourceCleanup', { |
There was a problem hiding this comment.
Could we add assertions to this test to GetCanary to get the Lambda layer, DeleteCanary and then verify the lambda layer does not exist?
There was a problem hiding this comment.
@gracelu0 I've updated integ test!
gracelu0
removed
the
pr/needs-maintainer-review
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
mergify
bot
dismissed
gracelu0’s stale review
Pull request has been modified.
aws-cdk-automation
added
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
None
Reason for this change
For the Lambda and Layer used in Canary, the deletion of related resources is handled by a custom resource, but this functionality is now supported natively by CloudFormation.
https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-synthetics-canary.html#cfn-synthetics-canary-provisionedresourcecleanup
Description of changes
provisionedResourceCleanupprop toCanaryPropscleanupprop which uses custom resourceDescribe any new or updated permissions being added
None
Description of how you validated changes
Add both unit and integ test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license