Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eks): nodegroup add missing AL2023 AMI type #32418

Merged
merged 5 commits into from
Dec 10, 2024
Merged

chore(eks): nodegroup add missing AL2023 AMI type #32418

merged 5 commits into from
Dec 10, 2024

Conversation

phuhung273
Copy link
Contributor

Issue # (if applicable)

Closes #32378

Reason for this change

  • Missing AL2023 AMI type

Description of changes

  • Add missing AL2023 AMI type

Description of how you validated changes

Integration test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Dec 8, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 8, 2024 09:56
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Dec 8, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (2607eb3) to head (a84e978).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #32418      +/-   ##
==========================================
- Coverage   78.67%   78.66%   -0.02%     
==========================================
  Files         107      107              
  Lines        7237     7237              
  Branches     1329     1329              
==========================================
- Hits         5694     5693       -1     
- Misses       1357     1358       +1     
  Partials      186      186
Flag Coverage Δ
suite.unit 78.66% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.66% <ø> (-0.02%) ⬇️

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 8, 2024
nmussy
nmussy suggested changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just an issue with the JSDoc

packages/@aws-cdk/aws-eks-v2-alpha/lib/managed-nodegroup.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-eks/lib/managed-nodegroup.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 8, 2024
@phuhung273 phuhung273 requested a review from nmussy December 9, 2024 01:08
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a84e978
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@GavinZZ
Copy link
Contributor

GavinZZ commented Dec 10, 2024

Bypassing the code coverage constraint on chore PR.

@GavinZZ GavinZZ merged commit 784c834 into aws:main Dec 10, 2024
22 of 25 checks passed
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2024
@phuhung273 phuhung273 deleted the eks-nodegroup-ami-type branch December 11, 2024 00:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GavinZZ GavinZZ GavinZZ approved these changes

@nmussy nmussy nmussy approved these changes

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EKS: AL2023 Nvidia instance type missing
4 participants
@phuhung273 @aws-cdk-automation @GavinZZ @nmussy