Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): prevent test interference #32270

Merged
merged 10 commits into from
Nov 25, 2024
Merged

chore(cli): prevent test interference #32270

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f732c9e
chore(cli): prevent test interference
rix0rrr Nov 25, 2024
4a72ac0
This is no longer necessary, and uncovered
rix0rrr Nov 25, 2024
88d06de
Add some coverage
rix0rrr Nov 25, 2024
910505a
Add tests
rix0rrr Nov 25, 2024
0c32162
Always chmod directory so developers can't locally `chmod` it back
rix0rrr Nov 25, 2024
e04f71e
Rename directory
rix0rrr Nov 25, 2024
58b9c2f
Run afterAll in reverse order
rix0rrr Nov 25, 2024
acfcfdc
Merge branch 'main' into huijbers/test-interference
rix0rrr Nov 25, 2024
415b32a
Cover that one line
rix0rrr Nov 25, 2024
a534e33
Merge branch 'huijbers/test-interference' of github.com:aws/aws-cdk i…
rix0rrr Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename directory
  • Loading branch information
@rix0rrr
rix0rrr committed Nov 25, 2024
commit e04f71e5658decee5ea68e005cc99ee04bfe2303
2 changes: 1 addition & 1 deletion packages/aws-cdk/test/jest-setup-after-env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ let tmpDir: string;
let oldDir: string;

beforeAll(() => {
tmpDir = path.join(os.tmpdir(), 'cdk-nonwritable');
tmpDir = path.join(os.tmpdir(), 'cdk-nonwritable-on-purpose');
fs.mkdirSync(tmpDir, { recursive: true });
fs.chmodSync(tmpDir, 0o500);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works too 👍

oldDir = process.cwd();
Expand Down
Loading