chore(cli-integ): new test case for proxied requests #32254
Conversation
otaviomacedo
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32254 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 105 105
Lines 7169 7169
Branches 1315 1315
=======================================
Hits 5533 5533
Misses 1455 1455
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
| @@ -179,7 +179,7 @@ function getRegionFromIniFile(profile: string, data?: any) { | |||
| function tryGetCACert(bundlePath?: string) { | |||
| const path = bundlePath || caBundlePathFromEnvironment(); | |||
| if (path) { | |||
| debug('Using CA bundle path: %s', bundlePath); | |||
| debug('Using CA bundle path: %s', path); | |||
There was a problem hiding this comment.
Codecov is failing because we don't have any unit test for this part, but the integ test in this PR covers precisely this branch.
otaviomacedo
added
the
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
This important scenario was missing from the integ test suite.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license