Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix(ecr): allow creating repository uri to use tokens like cfn params" #32241

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Leo10Gama
Copy link
Member

Reverts #32053 to fix #32238

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p0 labels Nov 22, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 22, 2024 00:10
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 22, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Leo10Gama Leo10Gama changed the title Revert "fix(ecr): allow creating repository uri to use tokens like cfn params" revert: "fix(ecr): allow creating repository uri to use tokens like cfn params" Nov 22, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 22, 2024 00:13

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@xazhao xazhao mentioned this pull request Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (68b969e) to head (4895de4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32241   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files         105      105           
  Lines        7169     7169           
  Branches     1315     1315           
=======================================
  Hits         5533     5533           
  Misses       1455     1455           
  Partials      181      181           
Flag Coverage Δ
suite.unit 77.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.17% <ø> (ø)
---- 🚨 Try these New Features:

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4895de4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b3e39a9 into main Nov 22, 2024
33 of 34 checks passed
@mergify mergify bot deleted the revert-32053-ecr-repo-uri-token branch November 22, 2024 00:42
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

❗️NOTICE: ECR: Template error: Cannot use Fn::ImportValue in Conditions.
3 participants