Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): 2.167.1 #32140

Merged
merged 3 commits into from
Nov 15, 2024
Merged

chore(release): 2.167.1 #32140

merged 3 commits into from
Nov 15, 2024

Commits on Nov 14, 2024

  1. fix(cli): failure to get credentials when session token is not set (#… 

    …32134)

In Node.js, if you assign `undefined` to an environment variable, that variable ends up having the string `"undefined"`.

If we are using IAM user credentials, `AWS_SESSION_TOKEN` should not be set, but because we were not handling this edge case, it was getting assigned an invalid value:

```
Welcome to Node.js v22.9.0.
Type ".help" for more information.
> process.env.AWS_SESSION_TOKEN || process.env.AMAZON_SESSION_TOKEN
undefined
> process.env.AWS_SESSION_TOKEN = process.env.AWS_SESSION_TOKEN || process.env.AMAZON_SESSION_TOKEN
undefined
> process.env.AWS_SESSION_TOKEN
'undefined'
```

Closes #32120.

### Checklist
- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @otaviomacedo @mrgrain
    otaviomacedo authored and mrgrain committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    425efbc View commit details
    Browse the repository at this point in the history

  2. fix(cli): region specified in ~/.aws/credentials is ignored (#32133) 

    We just didn't consider the shared credentials file as returned by the SDK when loading configuration. 

Closes #32130.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @iliapolo @mrgrain
    iliapolo authored and mrgrain committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9859f33 View commit details
    Browse the repository at this point in the history

  3. chore(release): 2.167.1

    @mrgrain
    mrgrain committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    36fd449 View commit details
    Browse the repository at this point in the history