Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(scheduler-alpha): increase unit test coverage #32033

Merged
merged 4 commits into from
Nov 6, 2024
Merged

chore(scheduler-alpha): increase unit test coverage #32033

merged 4 commits into from
Nov 6, 2024

Conversation

gracelu0
Copy link
Contributor

@gracelu0 gracelu0 commented Nov 6, 2024 •
edited
Loading

Issue # (if applicable)

tracking issue: #31785

Reason for this change

Satisfy 90% unit test coverage required for developer preview (see https://github.com/cdklabs/team-internal/blob/main/docs/construct-library-lifecycle.md#exit-criteria-1)

Description of changes

Added parameterized unit tests for metric methods

Previous coverage summary:

=============================== Coverage summary ===============================
Statements   : 83.06% ( 103/124 )
Branches     : 76.19% ( 32/42 )
Functions    : 70.9% ( 39/55 )
Lines        : 83.47% ( 101/121 )
================================================================================

Current coverage summary:

=============================== Coverage summary ===============================
Statements   : 95.16% ( 118/124 )
Branches     : 83.33% ( 35/42 )
Functions    : 96.36% ( 53/55 )
Lines        : 95.86% ( 116/121 )
================================================================================

Description of how you validated changes

Unit tests pass

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 6, 2024 04:41
@github-actions github-actions bot added the p2 label Nov 6, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 6, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 6, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 6, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d2e23fe
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit dd61d12 into aws:main Nov 6, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moelasmar moelasmar moelasmar approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gracelu0 @aws-cdk-automation @moelasmar