Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ec2): add missing interface VPC endpoint #31991

Merged
merged 2 commits into from
Nov 5, 2024
Merged

chore(ec2): add missing interface VPC endpoint #31991

merged 2 commits into from
Nov 5, 2024

Conversation

seanCladonema
Copy link
Contributor

Issue # (if applicable)

None

Reason for this change

Cost optimization hub interface VPC endpoint is not supported by AWS CDK.

Description of changes

Add cost optimization hub interface VPC endpoint.

Description of how you validated changes

aws ec2 describe-vpc-endpoint-services --filters Name=service-type,Values=Interface Name=owner,Values=amazon --region us-east-1 --query ServiceNames | grep cost-optimization-hub
    "com.amazonaws.us-east-1.cost-optimization-hub",

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Nov 2, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 2, 2024 09:14
@github-actions github-actions bot added the p2 label Nov 2, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 2, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@badmintoncryer
Copy link
Contributor

@seanCladonema Thank you for you contribution!
The PR title needs to follow the conventional commit format. Could you start it with chore(ec2)?

@seanCladonema seanCladonema changed the title add cost optimization hub interface endpoint to ec2 chore(ec2): add missing interface VPC endpoint Nov 3, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 3, 2024 02:31

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 3, 2024
@seanCladonema
Copy link
Contributor Author

@badmintoncryer
fixed!

@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Closed
Leo10Gama
Leo10Gama previously approved these changes Nov 4, 2024
View reviewed changes
@Leo10Gama
Copy link
Member

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed Leo10Gama’s stale review November 5, 2024 21:33

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a7a9d30
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 5, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 420be7a into aws:main Nov 5, 2024
16 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@badmintoncryer badmintoncryer badmintoncryer approved these changes

@Leo10Gama Leo10Gama Leo10Gama approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanCladonema @badmintoncryer @Leo10Gama @aws-cdk-automation