-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(opensearch): add I4G to list of OpenSearch nodes not requiring EBS volumes #31948
fix(opensearch): add I4G to list of OpenSearch nodes not requiring EBS volumes #31948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
dee66c7
to
96c395d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming with open search documentation:
The i4g instance types require Elasticsearch 7.9 or later or any version of OpenSearch, and do not support EBS storage volumes.
Thanks for the PR @aymen-chetoui
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #31764
Reason for this change
CDK is failing to deploy OpenSearch with I4G nodes with error message indicating that EBS configuration is required.
However, OpenSearch clusters with I4G nodes use instance store and cannot be configured with EBS storage.
Description of changes
This change adds I4G node type to the list of OpenSearch nodes that does not support EBS volumes in the cluster configuration.
Description of how you validated changes
Added unit tests and run them successfully
Ran integration test on private account
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license