Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cdk): increase coverage limits #31936

Merged
merged 2 commits into from
Oct 29, 2024
Merged

chore(cdk): increase coverage limits #31936

merged 2 commits into from
Oct 29, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Oct 29, 2024 •
edited
Loading

Issue

Relates to #31931

Reason for this change

The AWS CLI currently requires comparatively low coverage by tests:

statements: 60
branches: 45

The actual coverage is thankfully higher:

=============================== Coverage summary ===============================
Statements   : 81.59% ( 5462/6694 )
Branches     : 68.05% ( 1764/2592 )
Functions    : 84.49% ( 1128/1335 )
Lines        : 81.9% ( 5211/6362 )
================================================================================

Make sure we don't drop below the current values.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 29, 2024 16:52
@github-actions github-actions bot added the p2 label Oct 29, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 29, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain mentioned this pull request Oct 29, 2024
Closed
@mrgrain mrgrain changed the title chore(aws-cdk): increase coverage limits chore(cdk): increase coverage limits Oct 29, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 29, 2024 17:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2a78c1b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 46e51f5 into main Oct 29, 2024
17 of 18 checks passed
@mergify mergify bot deleted the mrgrain/chore/increase/coverage-limits branch October 29, 2024 17:25
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sumupitchayan sumupitchayan sumupitchayan approved these changes

@rix0rrr rix0rrr rix0rrr approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrgrain @aws-cdk-automation @rix0rrr @sumupitchayan