Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amplify-alpha): removing customResponseHeaders property does not remove the headers from the app #31844

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(amplify-alpha): removing customResponseHeaders property does not remove the headers from the app #31844

wants to merge 2 commits into from

Conversation

georeeve
Copy link

Issue # (if applicable)

Closes #31783.

Reason for this change

After setting the customResponseHeaders property to some value in the App construct, removing it again does not remove the headers in the Amplify console.

Description of changes

I have set the customHeaders property to a default value of an empty string. This sets the relevant CloudFormation property when customResponseHeaders is not provided, therefore overriding any previous values with an empty string. I took a look at a similar issue of removing basic auth from an app and saw we did something similar there - #15243.

Description of how you validated changes

Updated the existing tests with the new default value.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Oct 22, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 22, 2024 08:34
aws-cdk-automation
aws-cdk-automation requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ed717cb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@georeeve
Copy link
Author

Exemption Request - I have updated the existing unit test, and integration test snapshots with the new default values. I'm not really sure what I could put in a new integration test, as it'd test the same values as the existing integration tests.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 22, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

This was referenced Oct 28, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(amplify-alpha): Removing customResponseHeaders property does not remove the headers from the app
2 participants
@georeeve @aws-cdk-automation