Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws_route53): cannot use CfnParameter.valueAsNumber for L2 RecordSet weight #31823

Merged
merged 8 commits into from
Oct 31, 2024
Merged

fix(aws_route53): cannot use CfnParameter.valueAsNumber for L2 RecordSet weight #31823

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
900f700
fix(aws_route53): cannot use CfnParameter.valueAsNumber for L2 Record…
nicholaschiasson Oct 19, 2024
44f4f65
Update integ test
nicholaschiasson Oct 24, 2024
5991639
Fix integration test
nicholaschiasson Oct 25, 2024
fc84fcf
Stabilizing integ test for record set weight from param
nicholaschiasson Oct 27, 2024
77a8fc5
Forcing length of record set identifier
nicholaschiasson Oct 27, 2024
78364da
Hopefully a good snapshot
nicholaschiasson Oct 27, 2024
09cfb00
Merge branch 'main' into nicholaschiasson/resolve-recordset-weight-fr…
mergify[bot] Oct 28, 2024
1a6f6ea
Merge branch 'main' into nicholaschiasson/resolve-recordset-weight-fr…
GavinZZ Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update integ test
  • Loading branch information
@nicholaschiasson
nicholaschiasson committed Oct 28, 2024
commit 44f4f657a22b38c5ac136360082bf47d1e582ab5
4 changes: 2 additions & 2 deletions ...pshot/Route53RecordWeightFromCfnParameterIntegDefaultTestDeployAssertB313B703.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...hot/Route53RecordWeightFromCfnParameterIntegDefaultTestDeployAssertB313B703.template.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions ...teg/test/aws-route53/test/integ.record-weight-from-cfnparameter.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...g.record-weight-from-cfnparameter.js.snapshot/record-weight-from-cfnparameter.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 13 additions & 13 deletions ...record-weight-from-cfnparameter.js.snapshot/record-weight-from-cfnparameter.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"aws:cdk:path": "record-weight-from-cfnparameter/HostedZone/Resource"
}
},
"WeightedRecord0183C6356": {
"RecordWeightedFromCfnParameter0FB5DFC65": {
"Type": "AWS::Route53::RecordSet",
"Properties": {
"HostedZoneId": {
Expand All @@ -27,7 +27,7 @@
{
"Ref": "RecordWeight0"
},
"_ID_recordweightedRecord080EC42DE"
"_ID_recordweigParameter04970FE98"
]
]
},
Expand All @@ -38,10 +38,10 @@
}
},
"Metadata": {
"aws:cdk:path": "record-weight-from-cfnparameter/WeightedRecord0/Resource"
"aws:cdk:path": "record-weight-from-cfnparameter/RecordWeightedFromCfnParameter0/Resource"
}
},
"WeightedRecord1901777B1": {
"RecordWeightedFromCfnParameter11D8E5896": {
"Type": "AWS::Route53::RecordSet",
"Properties": {
"HostedZoneId": {
Expand All @@ -59,7 +59,7 @@
{
"Ref": "RecordWeight1"
},
"_ID_recordweightedRecord118B8FA43"
"_ID_recordweigParameter1EB51A657"
]
]
},
Expand All @@ -70,10 +70,10 @@
}
},
"Metadata": {
"aws:cdk:path": "record-weight-from-cfnparameter/WeightedRecord1/Resource"
"aws:cdk:path": "record-weight-from-cfnparameter/RecordWeightedFromCfnParameter1/Resource"
}
},
"WeightedRecord2D4D415A2": {
"RecordWeightedFromCfnParameter2B12A1DFB": {
"Type": "AWS::Route53::RecordSet",
"Properties": {
"HostedZoneId": {
Expand All @@ -91,7 +91,7 @@
{
"Ref": "RecordWeight2"
},
"_ID_recordweightedRecord29D395B6F"
"_ID_recordweigParameter208409FED"
]
]
},
Expand All @@ -102,10 +102,10 @@
}
},
"Metadata": {
"aws:cdk:path": "record-weight-from-cfnparameter/WeightedRecord2/Resource"
"aws:cdk:path": "record-weight-from-cfnparameter/RecordWeightedFromCfnParameter2/Resource"
}
},
"WeightedRecord328406D0A": {
"RecordWeightedFromCfnParameter3D5E67423": {
"Type": "AWS::Route53::RecordSet",
"Properties": {
"HostedZoneId": {
Expand All @@ -123,7 +123,7 @@
{
"Ref": "RecordWeight3"
},
"_ID_recordweightedRecord38AAB01D6"
"_ID_recordweigParameter3841525F4"
]
]
},
Expand All @@ -134,13 +134,13 @@
}
},
"Metadata": {
"aws:cdk:path": "record-weight-from-cfnparameter/WeightedRecord3/Resource"
"aws:cdk:path": "record-weight-from-cfnparameter/RecordWeightedFromCfnParameter3/Resource"
}
},
"CDKMetadata": {
"Type": "AWS::CDK::Metadata",
"Properties": {
"Analytics": "v2:deflate64:H4sIAAAAAAAA/02OvQ7CMBCDn4U9OUIRYkZdGKt2Y0FpckjXn5yUXGCo+u60ZGGy/VmWbMCAOdhP0s6PeqIelk6sG9WGnpGz4OUMS5P7idydk6B/cEBVv8JfurXoOPqdFtehrHtqbLQzCsZSJc7R/cY1B09CHFYV2CMM6fiuDJyu25khEemYg9CM0Bb9AmpStzOnAAAA"
"Analytics": "v2:deflate64:H4sIAAAAAAAA/02Luw7CMBAEvyW9fZggJFqUhjJKOhrk2Id0efgk+0yKKP+Oghuq3ZnVGjBgKrsm7fykZxpg68W6Sdk1vSJnwesFtjYPM7kHJ0H/5ICqeYc/unfoOPrDltaj7Ae1NtoFBWOZEufofueGgychDrsK7BHGdPrUBs43MNWYiHTMQWhB6Ep+AaNZotCnAAAA"
},
"Metadata": {
"aws:cdk:path": "record-weight-from-cfnparameter/CDKMetadata/Default"
Expand Down
40 changes: 20 additions & 20 deletions ...k-integ/test/aws-route53/test/integ.record-weight-from-cfnparameter.js.snapshot/tree.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...dk-testing/framework-integ/test/aws-route53/test/integ.record-weight-from-cfnparameter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class TestStack extends Stack {
{ target: '3.4.5.6', weight: new CfnParameter(this, 'RecordWeight2', weightParameterProps) },
{ target: '4.5.6.7', weight: new CfnParameter(this, 'RecordWeight3', weightParameterProps) },
].forEach((data, index) => {
new route53.ARecord(this, `WeightedRecord${index}`, {
new route53.ARecord(this, `RecordWeightedFromCfnParameter${index}`, {
zone: hostedZone,
recordName: 'www',
weight: data.weight.valueAsNumber,
Expand Down