Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2): allow NAT instance to associate public IP #31812

Merged
merged 7 commits into from
Oct 22, 2024
Merged

fix(ec2): allow NAT instance to associate public IP #31812

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
46409f1
fix(ec2): allow NAT instance to associate public IP
GavinZZ Oct 18, 2024
9701509
remove unwanted change
GavinZZ Oct 18, 2024
ce2545c
remove unwanted change
GavinZZ Oct 18, 2024
af0ed53
remove unwanted change
GavinZZ Oct 19, 2024
a987160
add comma
GavinZZ Oct 21, 2024
943b1c8
update docstring
GavinZZ Oct 22, 2024
7208988
Merge branch 'main' into yuanhaoz/nat_fix
mergify[bot] Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add comma
  • Loading branch information
@GavinZZ
GavinZZ committed Oct 21, 2024
commit a9871600bd687bdb7f5d697f6d5357046bb7ae78
7 changes: 3 additions & 4 deletions packages/aws-cdk-lib/aws-ec2/test/vpc.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
InterfaceVpcEndpointService,
NatProvider,
NatGatewayProvider,
NatInstanceProviderV2,
NatInstanceProvider,
NatTrafficDirection,
NetworkAcl,
Expand Down Expand Up @@ -1787,10 +1786,10 @@ describe('vpc', () => {
Template.fromStack(stack).hasResource('AWS::EC2::Instance', Match.objectLike({
Properties: {
NetworkInterfaces: [{
AssociatePublicIpAddress: value
AssociatePublicIpAddress: value,
}],
}
}))
},
}));
});

test('Can instantiate NatInstanceProvider directly with new', () => {
Expand Down