chore: npm-check-updates && yarn upgrade #31698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
added
auto-approve
contribution/core
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aws-cdk-automation
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
TheRealAmazonKendra
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
aws-cdk-automation
force-pushed
the
automation/yarn-upgrade
branch
from
6b0ce94
to
ec83bb5
Compare
aws-cdk-automation
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
aws-cdk-automation
force-pushed
the
automation/yarn-upgrade
branch
from
ec83bb5
to
10c6235
Compare
aws-cdk-automation
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
moelasmar
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
aws-cdk-automation
force-pushed
the
automation/yarn-upgrade
branch
from
4c16d11
to
6d8f412
Compare
aws-cdk-automation
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
Leo10Gama
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
Leo10Gama
added
pr/do-not-merge
Leo10Gama
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
Leo10Gama
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
aws-cdk-automation
added
the
pr/needs-maintainer-review
moelasmar
reviewed
Oct 24, 2024
| @@ -83,7 +83,7 @@ const beanstalkEnv = new elasticbeanstalk.CfnEnvironment(stack, 'beanstlk-env', | |||
| applicationName: beanstalkApp.applicationName!, | |||
| environmentName: 'codepipeline-test-env', | |||
| // see https://docs.aws.amazon.com/elasticbeanstalk/latest/platforms/platforms-supported.html#platforms-supported.nodejs | |||
| solutionStackName: '64bit Amazon Linux 2023 v6.2.1 running Node.js 20', | |||
| solutionStackName: '64bit Amazon Linux 2023 v6.2.2 running Node.js 20', | |||
There was a problem hiding this comment.
@Leo10Gama .. did you manually do this change?
There was a problem hiding this comment.
Yes, I manually changed it. According to their platform history, this value is not current, so no longer supported. Trying to deploy with it gave me this error:
❌ aws-cdk-codepipeline-elastic-beanstalk-deploy failed:
The stack named aws-cdk-codepipeline-elastic-beanstalk-deploy failed creation, it may need to be manually deleted from the AWS console:
ROLLBACK_COMPLETE:
Resource handler returned message:
"No Solution Stack named '64bit Amazon Linux 2023 v6.2.1 running Node.js 20' found. (Service: ElasticBeanstalk, Status Code: 400, Request ID: <ID>)" (RequestToken: <TOKEN>, HandlerErrorCode: InvalidRequest)
FAILED aws-codepipeline-actions/test/integ.pipeline-elastic-beanstalk-deploy-codepipeline-elastic-beanstalk-deploy/DefaultTest (undefined/us-east-1) 211.99s
Integration test failed: Error: Command exited with status 1
Updating the value let the test pass.
moelasmar
approved these changes
Oct 24, 2024
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran npm-check-updates and yarn upgrade to keep the
yarn.lockfile up-to-date.