fix(core): cdk diff on large templates fails when passing in toolkitStackName and qualifier
#31636
Conversation
Signed-off-by: Sumu <[email protected]>
sumupitchayan
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Signed-off-by: Sumu <[email protected]>
sumupitchayan
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
Signed-off-by: Sumu <[email protected]>
sumupitchayan
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
aws-cdk-automation
added
the
pr/needs-cli-test-run
github-actions
bot
added
bug
sumupitchayan
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
sumupitchayan
added
the
pr-linter/exempt-integ-test
Signed-off-by: Sumu <[email protected]>
…ier' of https://github.com/aws/aws-cdk into sumughan/fix/diff-with-custom-bootstrap-name-and-qualifier
sumupitchayan
changed the title
cdk diff on large templates fails when passing in toolkitStackName and qualifier
sumupitchayan
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
sumupitchayan
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
… integ test to succeed Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
sumupitchayan
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
sumupitchayan
added
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mergify
bot
deleted the
sumughan/fix/diff-with-custom-bootstrap-name-and-qualifier
branch
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Closes #29179
Reason for this change
If your account is bootstrapped with a custom
toolkitStackNameorqualifier, then runningcdk diffdoes not work for large diff templates of over 50 KiB in size.Description of changes
The
toolkitStackNamewas not passed down all the way through thecdk diffcode path - this PR fixes the issue by adding the optionaltoolkitStackNameproperty to theDiffOptionsinterface incdk-toolkit.tsand passing that value all the way through the diff code path to theuploadBodyParameterAndCreateChangeSetfunction incloudformation.ts, where the template asset is built and published.Description of how you validated changes
I created a CDK app locally and ran the commands (exactly following the reproduction steps from the original issue) using the CLI build from this PR and was able to successfully run
cdk diffwithout needing to pass in the--toolkit-stack-nameflag.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license