fix(cli-lib): deploy fails with "no such file or directory, open 'node_modules/@aws-cdk/integ-runner/lib/workers/db.json.gz'" #28199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mrgrain
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mrgrain
force-pushed
the
mrgrain/fix/cli-lib-broken
branch
from
8c48beb to
ce1436b
Compare
mrgrain
commented
Nov 30, 2023
| @@ -65,6 +65,7 @@ | |||
| "yarn attribute", | |||
| "mkdir -p ./lib/api/bootstrap/ && cp ../../aws-cdk/lib/api/bootstrap/bootstrap-template.yaml ./lib/api/bootstrap/", | |||
| "cp ../../../node_modules/cdk-from-cfn/index_bg.wasm ./lib/", | |||
| "cp ../../../node_modules/@aws-cdk/aws-service-spec/db.json.gz ./", | |||
There was a problem hiding this comment.
This is the fix. We cannot depend on @aws-cdk/aws-service-spec since cli-lib is a jsii package, and service-spec is not.
mrgrain
force-pushed
the
mrgrain/fix/cli-lib-broken
branch
from
ce1436b to
ed9e086
Compare
aws-cdk-automation
added
the
pr/needs-maintainer-review
mrgrain
force-pushed
the
mrgrain/fix/cli-lib-broken
branch
from
ed9e086 to
84e5f4d
Compare
…n './node_modules/@aws-cdk/cli-lib-alpha/db.json.gz'
mrgrain
force-pushed
the
mrgrain/fix/cli-lib-broken
branch
from
84e5f4d to
83a7a32
Compare
rix0rrr
approved these changes
Nov 30, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
chenjane-dev
pushed a commit
to chenjane-dev/aws-cdk
that referenced
this pull request
Dec 5, 2023
…e_modules/@aws-cdk/integ-runner/lib/workers/db.json.gz'" (aws#28199) After aws#27813 the `deploy` action was broken with the above error. This is effectively the same as aws#27983 . To ensure these kind of issues are not slipping through again, the PR is adding a basic testing harness for `cli-lib` to `@aws-cdk-testing/cli-integtests`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #27813 the
deployaction was broken with the above error. This is effectively the same as #27983 .To ensure these kind of issues are not slipping through again, the PR is adding a basic testing harness for
cli-libto@aws-cdk-testing/cli-integtests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license