Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda-python-alpha): add without-urls option for poetry #27442

Merged
merged 6 commits into from
Oct 10, 2023
Merged

feat(lambda-python-alpha): add without-urls option for poetry #27442

merged 6 commits into from
Oct 10, 2023

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Oct 7, 2023 •
edited
Loading

Added without-urls option for poetry. Also added Python versions for the integration tests.

Closes #27103.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 7, 2023 20:28
@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Oct 7, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 7, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 9, 2023 02:02

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 9, 2023
lpizzinidev
lpizzinidev suggested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💪
The implementation looks good.
Some adjustments are needed on documentation and tests in my opinion.

packages/@aws-cdk/aws-lambda-python-alpha/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-python-alpha/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-python-alpha/test/bundling.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-python-alpha/test/integ.function.poetry.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 9, 2023
msambol
msambol commented Oct 9, 2023
View reviewed changes
packages/@aws-cdk/aws-lambda-python-alpha/test/lambda-handler-poetry/basic.py
def handler(event, context):
print('Basic handler')

return 200
Copy link
Contributor Author

@msambol msambol Oct 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this basic handler with no dependencies for Python <= 3.8.

lpizzinidev
lpizzinidev approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💪

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 10, 2023
sumupitchayan
sumupitchayan approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@sumupitchayan sumupitchayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - thank you for your contribution!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e14b668
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5893b3f into aws:main Oct 10, 2023
10 checks passed
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumupitchayan sumupitchayan sumupitchayan approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@aws-cdk/aws-lambda-python-alpha: allow "--without-urls" option to poetry export
4 participants
@msambol @aws-cdk-automation @lpizzinidev @sumupitchayan