Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integ-tests): cannot make two or more identical assertions #27380

Merged
merged 10 commits into from
Oct 10, 2023
Merged

fix(integ-tests): cannot make two or more identical assertions #27380

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
64d761f
fix(integ-tests): allow multiple identical invocations
misterjoshua Oct 2, 2023
1029ed2
update integration test
misterjoshua Oct 3, 2023
135fe0a
fix equality
misterjoshua Oct 3, 2023
f8bfb2e
add invokeFunction test case
misterjoshua Oct 3, 2023
d8b0441
deplossert -> deployAssert
misterjoshua Oct 3, 2023
2bf7fe4
Merge branch 'main' into fix-22043
misterjoshua Oct 6, 2023
ac51837
Merge branch 'main' into fix-22043
misterjoshua Oct 9, 2023
b845f35
Merge branch 'main' into fix-22043
SankyRed Oct 10, 2023
9194a5b
Merge branch 'main' into fix-22043
SankyRed Oct 10, 2023
6b3e0ab
Merge branch 'main' into fix-22043
mergify[bot] Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deplossert -> deployAssert
  • Loading branch information
@misterjoshua
misterjoshua committed Oct 3, 2023
commit d8b0441b6b5b0de42c4ac419f4fbe45d0367cf3a
16 changes: 8 additions & 8 deletions packages/@aws-cdk/integ-tests-alpha/test/assertions/deploy-assert.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,12 @@ describe('DeployAssert', () => {
const app = new App();

// WHEN
const deplossert = new DeployAssert(app);
deplossert.awsApiCall('MyService', 'MyApi');
deplossert.awsApiCall('MyService', 'MyApi');
const deployAssert = new DeployAssert(app);
deployAssert.awsApiCall('MyService', 'MyApi');
deployAssert.awsApiCall('MyService', 'MyApi');

// THEN
const template = Template.fromStack(deplossert.scope);
const template = Template.fromStack(deployAssert.scope);
template.resourceCountIs('AWS::Lambda::Function', 1);
template.resourceCountIs('Custom::DeployAssert@SdkCallMyServiceMyApi', 2);
});
Expand Down Expand Up @@ -238,12 +238,12 @@ describe('DeployAssert', () => {
const app = new App();

// WHEN
const deplossert = new DeployAssert(app);
deplossert.httpApiCall('https://example.com/test');
deplossert.httpApiCall('https://example.com/test');
const deployAssert = new DeployAssert(app);
deployAssert.httpApiCall('https://example.com/test');
deployAssert.httpApiCall('https://example.com/test');

// THEN
const template = Template.fromStack(deplossert.scope);
const template = Template.fromStack(deployAssert.scope);
template.resourceCountIs('AWS::Lambda::Function', 1);
template.resourceCountIs('Custom::DeployAssert@HttpCallexamplecomtest', 2);
});
Expand Down