Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apprunner): incorrect serviceName #26015

Merged
merged 5 commits into from
Jun 20, 2023
Merged

fix(apprunner): incorrect serviceName #26015

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd52efc
fix serviceName
pahud Jun 16, 2023
8474f8c
update test
pahud Jun 16, 2023
2b72b09
minor
pahud Jun 16, 2023
a9c51ed
Merge branch 'main' into pahud/aws-apprunner-alpha-servicename-26002
mergify[bot] Jun 19, 2023
27b7185
Merge branch 'main' into pahud/aws-apprunner-alpha-servicename-26002
mergify[bot] Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor
  • Loading branch information
@pahud
pahud committed Jun 16, 2023
commit 2b72b0995e97328dda571fed150bf3a08c93ac06
3 changes: 3 additions & 0 deletions packages/@aws-cdk/aws-apprunner-alpha/test/service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,9 @@ test('serviceName validation', () => {
});

// THEN
// the serviceName should not be the resource.ref
expect(svc.serviceName).not.toEqual((svc.node.defaultChild as cdk.CfnResource).ref);
// serviceName and serviceArn should be different
expect(svc.serviceName).not.toEqual(svc.serviceArn);
});

Expand Down