Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix json in issue-label-assign #26000

Merged
merged 3 commits into from
Jun 15, 2023
Merged

chore: fix json in issue-label-assign #26000

merged 3 commits into from
Jun 15, 2023

Conversation

yasminetalby
Copy link
Contributor

@yasminetalby yasminetalby commented Jun 15, 2023 •
edited by peterwoodworth
Loading

Fixes error in issue-label-assign JSON

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@yasminetalby
Update issue-label-assign.yml
bffb0d1 
Fix Error: Unexpected token @ in JSON at position 29901
@yasminetalby
Merge pull request #1 from yasminetalby/fix-issue-label-assign
21771f7 
Update issue-label-assign.yml
@gitpod-io
Copy link

gitpod-io bot commented Jun 15, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 15, 2023 20:41
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jun 15, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@peterwoodworth peterwoodworth changed the title Fix Error: Unexpected token @ in JSON at position 29901 chore: fix json in issue-label-assign Jun 15, 2023
peterwoodworth
peterwoodworth previously requested changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yasmine! We'll need to remove that last quotation mark as well for this to be valid 🙂

@aws-cdk-automation aws-cdk-automation dismissed their stale review June 15, 2023 20:48

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

yasminetalby
yasminetalby commented Jun 15, 2023
View reviewed changes
Copy link
Contributor Author

@yasminetalby yasminetalby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the last one! Thank you for pointing it out Peter:)

@mergify mergify bot dismissed peterwoodworth’s stale review June 15, 2023 20:57

Pull request has been modified.

@peterwoodworth
Copy link
Contributor

Thanks a ton Yasmine 🎉

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: aeed084
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4c9016a into aws:main Jun 15, 2023
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwoodworth peterwoodworth peterwoodworth approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yasminetalby @peterwoodworth @aws-cdk-automation