fix(efs): change logical id for EfsMountTarget #25996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
repeat-contributor
aws-cdk-automation
requested changes
Jun 15, 2023
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
ahmetsoykan
changed the title
aws-cdk-automation
added
pr-linter/exemption-requested
ahmetsoykan
force-pushed
the
25099
branch
2 times, most recently
from
14c3197 to
dad108b
Compare
aws-cdk-automation
removed
the
pr-linter/exemption-requested
|
Exemption Request from needing an integration test |
aws-cdk-automation
added
the
pr-linter/exemption-requested
ahmetsoykan
force-pushed
the
25099
branch
2 times, most recently
from
89dd111 to
e066f17
Compare
fix(aws-efs): change logical id for EfsMountTarget fix(aws-efs): change logical id for EfsMountTarget fix(aws-efs): change logical id for EfsMountTarget fix(aws-efs): change logical id for EfsMountTarget fix(aws-efs): change logical id for EfsMountTarget fix(aws-efs): change logical id for EfsMountTarget fix(aws-efs): change logical id for EfsMountTarget fix(aws-efs): change logical id for EfsMountTarget fix(aws-efs): change logical id for EfsMountTarget fix(aws-efs): change logical id for EfsMountTarget
corymhall
suggested changes
Jun 27, 2023
corymhall
removed
the
pr/needs-community-review
Co-authored-by: Cory Hall <[email protected]>
Co-authored-by: Cory Hall <[email protected]>
Co-authored-by: Cory Hall <[email protected]>
Co-authored-by: Cory Hall <[email protected]>
This would add workflow for handling Q & A discussions. > [CONTRIBUTING GUIDE]: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md > [DESIGN GUIDELINES]: https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md Closes #<issue number here>. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#26129) Allow selecting the region that was bootstrapped to be distinct from the region that the stack is being deployed to. Also in this PR, clarify the README. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Due to the addition of noctilucent to cdk, contributors needed to download rust/rustup to be able to build the cdk. This uses the pre-existing dependency on Docker/Finch to containerize the process in order to not incur any further dependencies for contributors to manage. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…of 10 and 1 in `Fn.conditionAnd()` (aws#25999) Closes aws#25696 (comment) Same solution as aws#25708 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This matches the behavior of [aws-cdk](https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk/package.json#L31-L35) When `integ-runner` is installed on a mac, `fsevents` will be installed as well. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#26154) Added write permission for github workflow action as required. This would eliminate the need for changing github repo settings as mentioned [here](https://github.com/aws-github-ops/handle-stale-discussions/blob/main/README.md#steps-to-enable-this-action-in-your-repository) > [CONTRIBUTING GUIDE]: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md > [DESIGN GUIDELINES]: https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md Closes #<issue number here>. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This reverts commit a25790e.
…)" This reverts commit 8bc499c.
This reverts commit 50d59f2.
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
could you check please the change under this PR ? Thank you, @corymhall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25099
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license