-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoscaling): deprecate launch configurations (under feature flag) #25910
Conversation
Signed-off-by: Francis <[email protected]>
…aunch config deprecation Signed-off-by: Francis <[email protected]>
…p v2 props interface and autoscaling group v2 props interface Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
… override to auto scaling group v2 class Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
… config props to launch template if feature flag is enabled Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
…unch config props when the feature flag is set Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
… on CfnLaunchTemplate based on whether or not network interfaces are specified Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
…ed dissociate public IP address test Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
…ress Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
…utoscaling disable launch config feature flag is set to true Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
…endency when instance profile is provided Signed-off-by: Francis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a couple minor things
…ly create a role if one is not provided Signed-off-by: Francis <[email protected]>
…and provided role Signed-off-by: Francis <[email protected]>
… profile and role being mutually exclusive in launch template Signed-off-by: Francis <[email protected]>
…ed template Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Signed-off-by: Francis <[email protected]>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…g) (aws#25910) This PR focuses on supporting the deprecation of launch configurations when creating an auto scaling group. All new accounts created after December 31, 2023 will no longer be able to create launch configurations. An equivalent launch template will now be created by the AutoScalingGroup construct instead of a launch configuration. Closes aws#23165 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…g) (aws#25910) This PR focuses on supporting the deprecation of launch configurations when creating an auto scaling group. All new accounts created after December 31, 2023 will no longer be able to create launch configurations. An equivalent launch template will now be created by the AutoScalingGroup construct instead of a launch configuration. Closes aws#23165 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR focuses on supporting the deprecation of launch configurations when creating an auto scaling group. All new accounts created after December 31, 2023 will no longer be able to create launch configurations. An equivalent launch template will now be created by the AutoScalingGroup construct instead of a launch configuration.
Closes #23165
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license