Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoscaling): deprecate launch configurations (under feature flag) #25910

Merged
merged 154 commits into from
Jul 6, 2023

Conversation

colifran
Copy link
Contributor

@colifran colifran commented Jun 8, 2023

This PR focuses on supporting the deprecation of launch configurations when creating an auto scaling group. All new accounts created after December 31, 2023 will no longer be able to create launch configurations. An equivalent launch template will now be created by the AutoScalingGroup construct instead of a launch configuration.

Closes #23165


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

colifran added 30 commits June 1, 2023 10:24
…p v2 props interface and autoscaling group v2 props interface

Signed-off-by: Francis <[email protected]>
… override to auto scaling group v2 class

Signed-off-by: Francis <[email protected]>
… config props to launch template if feature flag is enabled

Signed-off-by: Francis <[email protected]>
…unch config props when the feature flag is set

Signed-off-by: Francis <[email protected]>
… on CfnLaunchTemplate based on whether or not network interfaces are specified

Signed-off-by: Francis <[email protected]>
…ed dissociate public IP address test

Signed-off-by: Francis <[email protected]>
…utoscaling disable launch config feature flag is set to true

Signed-off-by: Francis <[email protected]>
@colifran colifran requested a review from corymhall July 5, 2023 12:56
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a couple minor things

@corymhall corymhall changed the title feat(autoscaling): deprecate launch configurations feat(autoscaling): deprecate launch configurations (under feature flag) Jul 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8c726f4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ff21c69 into main Jul 6, 2023
@mergify mergify bot deleted the colifran/asg-launch-config-dep branch July 6, 2023 18:33
tmokmss pushed a commit to tmokmss/aws-cdk that referenced this pull request Jul 9, 2023
…g) (aws#25910)

This PR focuses on supporting the deprecation of launch configurations when creating an auto scaling group. All new accounts created after December 31, 2023 will no longer be able to create launch configurations. An equivalent launch template will now be created by the AutoScalingGroup construct instead of a launch configuration.

Closes aws#23165

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
…g) (aws#25910)

This PR focuses on supporting the deprecation of launch configurations when creating an auto scaling group. All new accounts created after December 31, 2023 will no longer be able to create launch configurations. An equivalent launch template will now be created by the AutoScalingGroup construct instead of a launch configuration.

Closes aws#23165

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-autoscaling: Use launch templates instead of deprecated launch configurations
4 participants