Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-cdk-lib): Add New ADOT Lambda Layer v0.30.0 ARNs #25909

Merged
merged 9 commits into from
Jun 19, 2023

Conversation

humivo
Copy link
Contributor

@humivo humivo commented Jun 8, 2023

This PR adds New ADOT Lambda Layers v0.30.0 in the CDK library


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 8, 2023

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jun 8, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 8, 2023 20:49
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@humivo humivo changed the title Add new adot lambda layer versions to aws cdk chore(aws-cdk-lib): Add New ADOT Lambda Layer v0.30.0 ARNs Jun 8, 2023
@humivo humivo requested a review from aws-cdk-automation June 8, 2023 20:52
@vasireddy99
Copy link
Contributor

LGTM!

@aws-cdk-automation aws-cdk-automation dismissed their stale review June 8, 2023 20:54

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@@ -609,6 +609,48 @@ export const PARAMS_AND_SECRETS_LAMBDA_LAYER_ARNS: { [version: string]: { [arch:
};

const ADOT_LAMBDA_LAYER_JAVA_SDK_ARNS: { [version: string]: { [arch: string]: { [region: string]: string } } } = {
'1.26.0': {
x86_64: {
'ap-northeast-1': 'arn:aws:lambda:ap-northeast-1:901920570463:layer:aws-otel-java-wrapper-amd64-ver-1-26-0:2',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a "Releases" page where we can see which versions have been released for each of these layers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have these PRs open to update our Releases pages with the new Lambda Layer versions but I have not merged them in yet as I am waiting for this PR to be merged before completing the release process:

otaviomacedo
otaviomacedo previously approved these changes Jun 15, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed otaviomacedo’s stale review June 15, 2023 16:07

Pull request has been modified.

@humivo humivo requested a review from otaviomacedo June 15, 2023 16:19
otaviomacedo
otaviomacedo previously approved these changes Jun 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed otaviomacedo’s stale review June 19, 2023 16:23

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d7b4255
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants