fix(ecs): remove accidental duplication of cloudmap namespaces with service connect #25891
Conversation
|
|
github-actions
bot
added
bug
github-actions
bot
added
the
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
bvtujo
force-pushed
the
fix/ecs-cluster-namespace-bug
branch
from
1bfb3af to
2b37d8d
Compare
aws-cdk-automation
added
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR should fix #25616, where service connect accidentally creates a duplicate HTTP namespace when a customer sets a service connect default namespace on the cluster.
Closes #25616
However, I think that a broader fix for this issue should include deprecation of the
namespaceparameter inServiceConnectPropsin favor of acloudmapNamespace: INamespaceparameter; that way, we can force resolution by ARN under the hood of the construct and never trigger the namespace duplication behavior.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license