Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cloudwatch): description for cloudwatch alarm actions #25853

Merged
merged 6 commits into from
Jun 14, 2023
Merged

docs(cloudwatch): description for cloudwatch alarm actions #25853

merged 6 commits into from
Jun 14, 2023

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Jun 5, 2023

As mentioned in the issue, some of the details of the argument types for the CloudWatch Alarm and CompositeAlarm methods are wrong.

Closes #22801

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 5, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 5, 2023 12:51
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Jun 5, 2023
@go-to-k go-to-k force-pushed the docs/fix-cloudwatch-alarm-action-docstrings branch from 6780280 to 5391990 Compare June 5, 2023 16:24
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 5, 2023
@go-to-k
Copy link
Contributor Author

go-to-k commented Jun 5, 2023 •
edited
Loading

Sorry, the AWS CodeBuild CI Report failed with internal health check errors at first commit, and I wanted to re-run the job so I re-committed and did a force push.

time="2023-06-05T13:09:46.513948150Z" level=error msg="healthcheck failed fatally" in the Build Logs.

kaizencc
kaizencc previously approved these changes Jun 6, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@go-to-k
Copy link
Contributor Author

go-to-k commented Jun 6, 2023

@kaizencc

As before, there seems to be a health check error in the CodeBuild, should I be concerned?

time="2023-06-06T15:20:36.490187349Z" level=error msg="healthcheck failed fatally"

@mergify mergify bot dismissed kaizencc’s stale review June 12, 2023 13:20

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: adb3a60
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d932fb7 into aws:main Jun 14, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@go-to-k go-to-k deleted the docs/fix-cloudwatch-alarm-action-docstrings branch June 14, 2023 12:27
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

@kaizencc kaizencc kaizencc left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_cloudwatch.CompositeAlarm: Wrong details on argument type in add_*_action(*actions) methods
5 participants
@go-to-k @aws-cdk-automation @otaviomacedo @kaizencc @corymhall