Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redshift): column compression encodings and comments can now be customised #24177

Merged
merged 39 commits into from
Mar 8, 2023
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
0f50d3f
addition: initial testing suite
Rizxcviii Jan 6, 2023
20fe7fa
addition: initial column encoding methods
Rizxcviii Jan 6, 2023
7517f8d
addition: docstring for ColumnEncoding
Rizxcviii Jan 6, 2023
8669223
addition: assigning enums to string variables
Rizxcviii Jan 6, 2023
38cfb4a
addition: adding encoding on creation of table
Rizxcviii Jan 6, 2023
656a307
addition: updates on column encoding
Rizxcviii Jan 6, 2023
7f2c6b9
addition: table comment and column comment
Rizxcviii Jan 6, 2023
5a72700
modification, addition
Rizxcviii Jan 6, 2023
77fe42c
Merge branch 'main' into feature/commentting-encoding
Rizxcviii Jan 6, 2023
68d8107
modification: integ test
Rizxcviii Jan 6, 2023
8689510
addition: docuementation for encoding and commentting
Rizxcviii Jan 6, 2023
73366fd
addition, modification:
Rizxcviii Jan 23, 2023
6f73d7a
modification: removing table comments code
Rizxcviii Jan 26, 2023
6ec1f26
modification: removing table comments code
Rizxcviii Jan 26, 2023
033bdc7
modification: integ test snapshot
Rizxcviii Jan 26, 2023
6a8ede8
modification: reverting import cleanup
Rizxcviii Jan 26, 2023
c8ac796
modification: removing table comments from README
Rizxcviii Jan 26, 2023
6ce5fa9
modification: bugfix, nested and incorrect test
Rizxcviii Jan 26, 2023
a96840c
modification: using private enum
Rizxcviii Jan 26, 2023
c4582e9
addition: line break on EOF
Rizxcviii Jan 26, 2023
2c13a23
Merge branch 'main' into feature/commentting-encoding
Rizxcviii Feb 6, 2023
07b6126
modification: using an actual compression encoding used by VARCHAR
Rizxcviii Feb 9, 2023
452d8ea
modification: rosetta fixing, was probably not run using the yarn com…
Rizxcviii Feb 9, 2023
461a93d
removal: lock file
Rizxcviii Feb 9, 2023
c78e737
modification: typo
Rizxcviii Feb 9, 2023
6a48280
Merge branch 'main' into feature/commentting-encoding
Rizxcviii Feb 14, 2023
e319510
linting
Rizxcviii Feb 15, 2023
a5c715b
updating README
Rizxcviii Feb 15, 2023
2662b65
Merge branch 'main' into feature/commentting-encoding
Rizxcviii Feb 16, 2023
88499ec
modification: post cdk update changes
Rizxcviii Feb 16, 2023
bdbc536
Merge branch 'main' into feature/commentting-encoding
Rizxcviii Feb 20, 2023
0cdebe6
Merge branch 'main' into feature/commentting-encoding
Rizxcviii Feb 21, 2023
783438e
typo
Rizxcviii Feb 21, 2023
3fb1a51
reverting unecessary change in integ test
Rizxcviii Feb 21, 2023
c006522
Merge branch 'main' into feature/commentting-encoding
Rizxcviii Feb 27, 2023
9b3c41e
Merge branch 'main' into feature/commentting-encoding
Rizxcviii Mar 3, 2023
b151288
updating README
Rizxcviii Mar 3, 2023
307e1b8
removing ColumnEncoding from private
Rizxcviii Mar 6, 2023
2613835
Merge branch 'main' into feature/commentting-encoding
comcalvi Mar 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
modification: removing table comments from README
  • Loading branch information
Rizxcviii committed Jan 26, 2023
commit c8ac7966a5673eb8a7f81b07e3f6441f7a2fa742
3 changes: 1 addition & 2 deletions packages/@aws-cdk/aws-redshift/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ new Table(this, 'Table', {
});
```

Both the table and their respective columns can be configured to contain comments:
Table columns can be configured to contain comments:

```ts fixture=cluster
new Table(this, 'Table', {
Expand All @@ -210,7 +210,6 @@ new Table(this, 'Table', {
],
cluster: cluster,
databaseName: 'databaseName',
comment: 'This is a comment',
});
```

Expand Down