Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cognito-identitypool): providerUrl causes error when mappingKey is not provided and it is a token #21191

Merged
merged 8 commits into from
Jul 30, 2022
+154 −2
Merged

fix(cognito-identitypool): providerUrl causes error when mappingKey is not provided and it is a token #21191

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4ce08e4
Add mappingKey to role mapping
SamStephens Jul 18, 2022
0eb4701
Add missing dependencies
SamStephens Jul 18, 2022
bbc6ae8
Update integ results
SamStephens Jul 18, 2022
2524a24
Merge branch 'main' into main
SamStephens Jul 18, 2022
192876d
Add missing IdentityPoolProviderUrl import to README.md
SamStephens Jul 18, 2022
68e96cc
Merge branch 'main' into main
SamStephens Jul 30, 2022
49af778
Fix providerUrl.value is token error message
SamStephens Jul 30, 2022
5ffb940
Fix test missed from previous commit
SamStephens Jul 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix providerUrl.value is token error message 
Update the wording of the error message when providerUrl.value is
a token as per request of @TheRealAmazonKendra
  • Loading branch information
@SamStephens
SamStephens committed Jul 30, 2022
commit 49af778a822c58d034c58fde626971d6a379a50c
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-cognito-identitypool/lib/identitypool-role-attachment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export class IdentityPoolRoleAttachment extends Resource implements IIdentityPoo
} else {
const providerUrl = prop.providerUrl.value;
if (Token.isUnresolved(providerUrl)) {
throw new Error('mappingKey must be provided when providerUrl.value is an unresolved token');
throw new Error('mappingKey must be provided when providerUrl.value is a token');
}
mappingKey = providerUrl;
}
Expand Down