feat(integ-tests): add IntegTest to group test cases#20015
feat(integ-tests): add IntegTest to group test cases#20015mergify[bot] merged 4 commits intomasterfrom
IntegTest to group test cases#20015Conversation
|
|
corymhall
left a comment
corymhall
left a comment
There was a problem hiding this comment.
Looks good, just 1 comment.
| */ | ||
| get manifest(): IntegManifest { | ||
| return { | ||
| version: '', |
There was a problem hiding this comment.
I think we need to use a valid semver version here. We will get errors when trying to read the manifest if this does not have a valid version. We will also probably need this once we go live so we can add new features that depend on certain versions.
There was a problem hiding this comment.
Good point. Fixed.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Add a new construct, `IntegTest` that contains a list of `IntegTestCase`s. This new construct is now responsible for starting the synthesis of the manifests. Previously, it was `IntegTestCase` that did this. But this results in the last `IntegTestCase` to be synthesized to override all other test cases. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
3 participants
Add a new construct,
IntegTestthat contains a list ofIntegTestCases. This new construct is now responsible for starting the synthesis of the manifests. Previously, it wasIntegTestCasethat did this. But this results in the lastIntegTestCaseto be synthesized to override all other test cases.All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license