Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apigatewayv2): http api - mTLS support #17284

Merged
merged 9 commits into from
Nov 9, 2021
Merged

feat(apigatewayv2): http api - mTLS support #17284

merged 9 commits into from
Nov 9, 2021

Conversation

serahisaactho
Copy link
Contributor

Resolves #12559

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 2, 2021

@serahisaactho serahisaactho marked this pull request as ready for review November 2, 2021 23:40
@peterwoodworth peterwoodworth changed the title feat(apigatewayv2): mTLS support feat(apigatewayv2): mTLS support Nov 3, 2021
@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label Nov 3, 2021
@nija-at nija-at changed the title feat(apigatewayv2): mTLS support feat(apigatewayv2): http api - mTLS support Nov 5, 2021
nija-at
nija-at previously approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR @serahisaactho.

@nija-at nija-at mentioned this pull request Nov 5, 2021
Closed
@mergify mergify bot dismissed nija-at’s stale review November 5, 2021 17:07

Pull request has been modified.

@nija-at
Copy link
Contributor

nija-at commented Nov 5, 2021

@serahisaactho - once approved, please do not update the branch from master. Our merge bot will do everything for you.

Any manual changes you make will revert the approval.

@serahisaactho
Copy link
Contributor Author

@nija-at Sorry! Thanks for taking a look

@serahisaactho
Copy link
Contributor Author

@nija-at It looks like the build is not successful which is blocking the merge. Can I update my branch to see what is causing the build failure?

@nija-at
Copy link
Contributor

nija-at commented Nov 8, 2021

That's weird that the build failed. I've restarted the build.

nija-at
nija-at previously approved these changes Nov 8, 2021
View reviewed changes
@mergify mergify bot dismissed nija-at’s stale review November 8, 2021 17:16

Pull request has been modified.

nija-at
nija-at previously requested changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serahisaactho - Your unit tests are failing. See the build logs linked above.

@serahisaactho
Copy link
Contributor Author

serahisaactho commented Nov 8, 2021 •
edited
Loading

@nija-at Will fix them. Is there another command to run the unit tests besides yarn test? The unit tests still seem to be passing locally for me. Nevermind, I needed to build the aws-s3 module again.

@mergify mergify bot dismissed nija-at’s stale review November 8, 2021 20:00

Pull request has been modified.

@serahisaactho
Copy link
Contributor Author

@nija-at I've updated the unit tests. The build is succeeding now.

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 1bd1cec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 54be156 into aws:master Nov 9, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@serahisaactho @TikiTDO
feat(apigatewayv2): http api - mTLS support (aws#17284)
fb63c70 
Resolves aws#12559 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(apigatewayv2): Expose DomainName mTLS config
3 participants
@serahisaactho @nija-at @aws-cdk-automation