Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opensearch): add I4G to list of OpenSearch nodes not requiring EBS volumes #31948

Conversation

aymen-chetoui
Copy link
Contributor

@aymen-chetoui aymen-chetoui commented Oct 30, 2024

Issue # (if applicable)

Closes #31764

Reason for this change

CDK is failing to deploy OpenSearch with I4G nodes with error message indicating that EBS configuration is required.
However, OpenSearch clusters with I4G nodes use instance store and cannot be configured with EBS storage.

Description of changes

This change adds I4G node type to the list of OpenSearch nodes that does not support EBS volumes in the cluster configuration.

Description of how you validated changes

Added unit tests and run them successfully
Ran integration test on private account

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 30, 2024 15:06
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Oct 30, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aymen-chetoui aymen-chetoui changed the title Add I4G to list of OpenSearch nodes not expecting EBS volumes fix(aws-opensearch): Add I4G to list of OpenSearch nodes not requiring EBS volumes Oct 30, 2024
@aymen-chetoui aymen-chetoui changed the title fix(aws-opensearch): Add I4G to list of OpenSearch nodes not requiring EBS volumes fix(opensearch): add I4G to list of OpenSearch nodes not requiring EBS volumes Oct 30, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 30, 2024 22:30

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aymen-chetoui aymen-chetoui force-pushed the fix-opensearch-expecting-ebs-config-for-i4g-nodes branch from dee66c7 to 96c395d Compare October 30, 2024 22:49
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 30, 2024
Copy link
Contributor

@sumupitchayan sumupitchayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming with open search documentation:

The i4g instance types require Elasticsearch 7.9 or later or any version of OpenSearch, and do not support EBS storage volumes.

Thanks for the PR @aymen-chetoui

@sumupitchayan sumupitchayan added pr/do-not-merge This PR should not be merged at this time. and removed pr/do-not-merge This PR should not be merged at this time. labels Nov 1, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 1, 2024
Copy link
Contributor

mergify bot commented Nov 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 23a9c07
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 73378f2 into aws:main Nov 1, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Nov 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

github-actions bot commented Nov 1, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws_opensearchservice): i4g instances say they need EBS
3 participants