Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ivs: support RecordingConfiguration for channel #31780

Closed
1 of 2 tasks
mazyu36 opened this issue Oct 16, 2024 · 2 comments · Fixed by #31899
Closed
1 of 2 tasks

ivs: support RecordingConfiguration for channel #31780

mazyu36 opened this issue Oct 16, 2024 · 2 comments · Fixed by #31899
Labels
@aws-cdk/aws-ivs Related to Amazon IVS effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented Oct 16, 2024

Describe the feature

RecordingConfiguration is not supported in current alpha Channel Construct.

Use Case

To use recording configuration.

Proposed Solution

  • Add RecordingConfiguration Construct.
  • Add recordingConfiguration property to the Channel.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.162.0

Environment details (OS name and version, etc.)

all
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 16, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ivs Related to Amazon IVS label Oct 16, 2024
@ashishdhingra ashishdhingra self-assigned this Oct 16, 2024
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 16, 2024
@ashishdhingra
Copy link
Contributor

ashishdhingra commented Oct 16, 2024 •
edited
Loading

@ashishdhingra ashishdhingra added effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Oct 16, 2024
@ashishdhingra ashishdhingra removed their assignment Oct 16, 2024
@mazyu36 mazyu36 mentioned this issue Oct 25, 2024
Merged
1 task
@github-actions github-actions bot mentioned this issue Nov 1, 2024
Closed
@mergify mergify bot closed this as completed in #31899 Nov 7, 2024
mergify bot pushed a commit that referenced this issue Nov 7, 2024
@mazyu36
feat(ivs): support recording configuration for channel (#31899)
8a3734d 
### Issue # (if applicable)

Closes #31780.

### Reason for this change
To use recording configuration for IVS channel.



### Description of changes
* Add `RecordingConfiguration` Construct.
* Add `recordingConfiguration` property to the Channel.



### Description of how you validated changes
Add unit tests and integ test.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2024
Leo10Gama pushed a commit to Leo10Gama/aws-cdk that referenced this issue Nov 13, 2024
@mazyu36
feat(ivs): support recording configuration for channel (aws#31899)
3ff07f3 
### Issue # (if applicable)

Closes aws#31780.

### Reason for this change
To use recording configuration for IVS channel.



### Description of changes
* Add `RecordingConfiguration` Construct.
* Add `recordingConfiguration` property to the Channel.



### Description of how you validated changes
Add unit tests and integ test.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-ivs Related to Amazon IVS effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ivs): support recording configuration for channel mazyu36/aws-cdk
2 participants
@mazyu36 @ashishdhingra