Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iot: support for scheduled audit configuration #31779

Closed
1 of 2 tasks
badmintoncryer opened this issue Oct 16, 2024 · 2 comments · Fixed by #31776
Closed
1 of 2 tasks

iot: support for scheduled audit configuration #31779

badmintoncryer opened this issue Oct 16, 2024 · 2 comments · Fixed by #31776
Labels
@aws-cdk/aws-iot Related to AWS IoT effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

Describe the feature

Add AWS IoT Scheduled Audit construct for AWS CDK.

Use Case

Cloudformation supports for creating scheduled audit configuration but CDK does not support this.

https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-iot-scheduledaudit.html

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.161.0

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 16, 2024
@github-actions github-actions bot added the @aws-cdk/aws-iot Related to AWS IoT label Oct 16, 2024
@badmintoncryer badmintoncryer mentioned this issue Oct 16, 2024
Merged
1 task
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Oct 16, 2024
@khushail khushail self-assigned this Oct 16, 2024
@khushail
Copy link
Contributor

Thanks @badmintoncryer for the request and submitting a PR!

@khushail khushail added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Oct 16, 2024
@khushail khushail removed their assignment Oct 16, 2024
@mergify mergify bot closed this as completed in #31776 Oct 21, 2024
mergify bot pushed a commit that referenced this issue Oct 21, 2024
@badmintoncryer
feat(iot): scheduled audit (#31776)
366b492 
### Issue # (if applicable)

Closes #31779.

### Reason for this change

Cloudformation supports for creating AWS IoT scheduled audit but AWS CDK does not.

### Description of changes

- Define `ScheduledAudit` construct

Cloudformation does not support two audit checks. Therefore I have not implemented these checks in the `AuditCheck` enum.
- INTERMEDIATE_CA_REVOKED_FOR_ACTIVE_DEVICE_CERTIFICATES_CHECK
- IOT_POLICY_POTENTIAL_MIS_CONFIGURATION_CHECK

If we try to deploy these checks, the deployment will fail.

```sh
Resource handler returned message: "Request contains an invalid Audit Check Name. (Service: Iot, Status Code: 400, Request ID: 3fb58c68-2845-4cc0-882c-7d9b5495ff2a)" (RequestToken: dcb09acd-609f-dfe5-7b63-6eb208052949, HandlerErrorCode: InvalidRequest)
```

### Description of how you validated changes

Added both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-iot Related to AWS IoT effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(iot): scheduled audit badmintoncryer/aws-cdk
2 participants
@badmintoncryer @khushail