(aws-glue-alpha): PythonRayExecutableProps are inaccurate #28570
Labels
@aws-cdk/aws-glue
Related to AWS Glue
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p2
Describe the bug
The options provided in
PythonRayExecutableProps
are not all useful for the Ray job type - for instance, theextraPythonFiles
andextraFiles
keys correspond to parameters on spark and plain python jobs, but not ray jobs.This could be a source of confusion (as was for me) for people looking to make use of the ray job
--s3-py-modules
parameter, which currently needs to be provided underdefaultArguments
.Expected Behavior
I would expect that any Ray specific arguments would be exposed under
PythonRayExecutableProps
and that non-ray parameters would not be.Current Behavior
The
extraPythonFiles
key has no effectReproduction Steps
Possible Solution
https://github.com/aws/aws-cdk/blob/v2.118.0/packages/@aws-cdk/aws-glue-alpha/lib/job-executable.ts#L256 -
PythonRayExecutableProps
is just an alias over the generic python job props and is not differentiated for Ray, which is a misleading experience. Fix would look like refactoring this to omit irrelevant props and include those missing.Additional Information/Context
No response
CDK CLI Version
2.113.0
Framework Version
No response
Node.js Version
v18.19.0
OS
macOS
Language
TypeScript
Language Version
5
Other information
No response
The text was updated successfully, but these errors were encountered: