Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-scheduler-targets-alpha): Add SqsSendMessage Target #27458

Closed
1 of 2 tasks
filletofish opened this issue Oct 9, 2023 · 2 comments · Fixed by #27774
Closed
1 of 2 tasks

(aws-scheduler-targets-alpha): Add SqsSendMessage Target #27458

filletofish opened this issue Oct 9, 2023 · 2 comments · Fixed by #27774
Labels
@aws-cdk/aws-scheduler Related to the AWS Scheduler service @aws-cdk/aws-scheduler-targets Related to targets of the AWS Scheduler service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@filletofish
Copy link
Contributor

Describe the feature

Work to support L2 constructs for AWS Scheduler is in progress (#23394). See the approved RFC. RFC planned to add 12 templates targets, but only Lambda Invoke is currently implemented (#26575).

This issue tracks implementation of SqsSendMessage target to send a message to an Amazon SQS Queue

Use Case

Customers would like to use templated target SqsSendMessage to be able to send a message to an Amazon SQS Queue on schedule. L2 target construct should grant required permissions to the AWS Scheduler to send a message to an Amazon SQS Queue.

Proposed Solution

The proposed solution needs to be adopted to the recent examples of LambdaInvoke (https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-scheduler-targets-alpha/lib/lambda-invoke.ts).

Solution should also include unit and integration tests.

Class SqsSendMessage should:

  1. Grant Scheduler Execution Role permissions to send a message to an Amazon SQS Queue via addTargetActionToRole
  2. Override bindBaseTargetConfig to return sqsParameters as part of ScheduleTargetConfig.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.99.1

Environment details (OS name and version, etc.)

MacOS
@filletofish filletofish added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 9, 2023
@github-actions github-actions bot added the @aws-cdk/aws-sqs Related to Amazon Simple Queue Service label Oct 9, 2023
@filletofish filletofish mentioned this issue Oct 9, 2023
Closed
2 tasks
@pahud
Copy link
Contributor

pahud commented Oct 9, 2023

Thank you for all those feature requests and PRs!

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 9, 2023
@kaizencc kaizencc added @aws-cdk/aws-scheduler Related to the AWS Scheduler service @aws-cdk/aws-scheduler-targets Related to targets of the AWS Scheduler service and removed @aws-cdk/aws-sqs Related to Amazon Simple Queue Service labels Oct 11, 2023
@go-to-k go-to-k mentioned this issue Oct 31, 2023
Merged
@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
@mergify mergify bot closed this as completed in #27774 Nov 21, 2023
mergify bot pushed a commit that referenced this issue Nov 21, 2023
@go-to-k
feat(scheduler-targets): SqsSendMessage Target (#27774)
80c1d26 
This PR adds `SqsSendMessage` Target for EventBridge Scheduler.

Closes #27458.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-scheduler Related to the AWS Scheduler service @aws-cdk/aws-scheduler-targets Related to targets of the AWS Scheduler service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(scheduler-targets): SqsSendMessage Target go-to-k/aws-cdk
3 participants
@pahud @filletofish @kaizencc