Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-scheduler-targets-alpha): Add InspectorStartAssessmentRun Target #27453

Closed
1 of 2 tasks
filletofish opened this issue Oct 9, 2023 · 2 comments · Fixed by #27850
Closed
1 of 2 tasks

(aws-scheduler-targets-alpha): Add InspectorStartAssessmentRun Target #27453

filletofish opened this issue Oct 9, 2023 · 2 comments · Fixed by #27850
Labels
@aws-cdk/aws-inspector Related to Amazon Inspector effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@filletofish
Copy link
Contributor

Describe the feature

Work to support L2 constructs for AWS Scheduler is in progress (#23394). See the approved RFC. RFC planned to add 12 templates targets, but only Lambda Invoke is currently implemented (#26575).

This issue tracks implementation of InspectorStartAssessmentRun target to start an AWS Inspector assessment run.

Use Case

Customers would like to use templated target InspectorStartAssessmentRun to be able to start a record to an AWS Inspector assessment run on schedule. L2 target construct should grant required permissions to the AWS Scheduler to start an AWS Inspector Assessment run.

Proposed Solution

The proposed solution needs to be adopted to the recent examples of LambdaInvoke (https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-scheduler-targets-alpha/lib/lambda-invoke.ts).

Solution should also include unit and integration tests.

  export class InspectorStartAssessmentRun extends ScheduleTargetBase implements IScheduleTarget {
    constructor(
      private readonly target: inspector.CfnAssessmentTarget,
      private readonly props: ScheduleTargetBaseProps,
    ) {
      super(props, target.attrArn);
    }

    protected addTargetActionToRole(schedule: ISchedule, role: IRole): void {
     // TODO: Check if target and schedule are in the same account and region
     // TODO: Check if target and role are in the same account

     // TODO: Check if L2 grant methods can be used
      role.addToPrincipalPolicy(new iam.PolicyStatement({
        actions: ['inpsector:StartAssessmentRun'],
        resources: ["*"],
      }));      
    }
  }

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.99.1

Environment details (OS name and version, etc.)

MacOS
@filletofish filletofish added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 9, 2023
@github-actions github-actions bot added the @aws-cdk/aws-inspector Related to Amazon Inspector label Oct 9, 2023
@filletofish filletofish mentioned this issue Oct 9, 2023
Closed
2 tasks
@pahud
Copy link
Contributor

pahud commented Oct 9, 2023

Thank you for all those feature requests and PRs!

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 9, 2023
@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
@go-to-k go-to-k mentioned this issue Nov 6, 2023
Merged
@mergify mergify bot closed this as completed in #27850 Nov 30, 2023
mergify bot pushed a commit that referenced this issue Nov 30, 2023
@go-to-k
feat(scheduler-targets-alpha): InspectorStartAssessmentRun Target (#…
073958f 
…27850)

This PR adds InspectorStartAssessmentRun Target for EventBridge Scheduler.

In [the issue](#27453), the `inspector.CfnAssessmentTarget` is used in the `InspectorStartAssessmentRun`. But it should be a `CfnAssessmentTemplate` so I fixed.

```ts
  export class InspectorStartAssessmentRun extends ScheduleTargetBase implements IScheduleTarget {
    constructor(
      private readonly target: inspector.CfnAssessmentTarget, // <- here
      private readonly props: ScheduleTargetBaseProps,
    ) {
```

Closes #27453.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

chenjane-dev pushed a commit to chenjane-dev/aws-cdk that referenced this issue Dec 5, 2023
@go-to-k @chenjane-dev
feat(scheduler-targets-alpha): InspectorStartAssessmentRun Target (a…
d045bd7 
…ws#27850)

This PR adds InspectorStartAssessmentRun Target for EventBridge Scheduler.

In [the issue](aws#27453), the `inspector.CfnAssessmentTarget` is used in the `InspectorStartAssessmentRun`. But it should be a `CfnAssessmentTemplate` so I fixed.

```ts
  export class InspectorStartAssessmentRun extends ScheduleTargetBase implements IScheduleTarget {
    constructor(
      private readonly target: inspector.CfnAssessmentTarget, // <- here
      private readonly props: ScheduleTargetBaseProps,
    ) {
```

Closes aws#27453.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-inspector Related to Amazon Inspector effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(scheduler-targets-alpha): InspectorStartAssessmentRun Target go-to-k/aws-cdk
2 participants
@pahud @filletofish