Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(apprunner-alpha): (Allow specify custom health endpoint) #26972

Closed
2 tasks
BosAtWork opened this issue Sep 1, 2023 · 3 comments · Fixed by #27029
Closed
2 tasks

(apprunner-alpha): (Allow specify custom health endpoint) #26972

BosAtWork opened this issue Sep 1, 2023 · 3 comments · Fixed by #27029
Labels
@aws-cdk/aws-apprunner Related to the apprunner package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@BosAtWork
Copy link

Describe the feature

By using the new apprunner alpha construct it is currently not possible to change the health configuration ourself.

This is the old apprunner health configuration: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_apprunner.CfnService.HealthCheckConfigurationProperty.html

But in the apprunner alpha package https://docs.aws.amazon.com/cdk/api/v2/docs/aws-apprunner-alpha-readme.html there is now way to change the health endpoint that should be used.

Use Case

I want to move a Spring Boot application from on-premise to apprunner. This already has an health endpoint in use called /actuator/health. I would like to use this for AppRunner instead of just the root path.

I want to use the alpha apprunner construct as it allows me to upload a docker asset as part of the CDK to make it easier to migrate to cloud for our existing applications.

Proposed Solution

Allow health configuration to be set in the apprunner alpha construct

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.93.0

Environment details (OS name and version, etc.)

typescript
@BosAtWork BosAtWork added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 1, 2023
@github-actions github-actions bot added the @aws-cdk/aws-apprunner Related to the apprunner package label Sep 1, 2023
@pahud
Copy link
Contributor

pahud commented Sep 5, 2023

Yes we'll need to support healthConfiguration in the service L2 construct.

We welcome any pull requsts for that.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2023
@go-to-k
Copy link
Contributor

go-to-k commented Sep 6, 2023

I'll take this issue.

@go-to-k go-to-k mentioned this issue Sep 6, 2023
Merged
@mergify mergify bot closed this as completed in #27029 Sep 27, 2023
mergify bot pushed a commit that referenced this issue Sep 27, 2023
@go-to-k
feat(apprunner): add HealthCheckConfiguration property in Service (#2…
4e8c9c4 
…7029)

This PR adds HealthCheckConfiguration property in Service construct.

Closes #26972.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-apprunner Related to the apprunner package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(apprunner): add HealthCheckConfiguration property in Service go-to-k/aws-cdk
3 participants
@pahud @BosAtWork @go-to-k