Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-batch-alpha: Missing ephemeralStorage configuration #25393

Closed
gael-ft opened this issue May 2, 2023 · 4 comments · Fixed by #25399
Closed

aws-batch-alpha: Missing ephemeralStorage configuration #25393

gael-ft opened this issue May 2, 2023 · 4 comments · Fixed by #25399
Labels
@aws-cdk/aws-batch Related to AWS Batch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@gael-ft
Copy link

gael-ft commented May 2, 2023

Describe the bug

AWS Batch using ECS Fargate should support setting the ephemeralStorage (< 200GiB).

I can't find any ways to do it currently

Expected Behavior

Having a ephemeralStorage property in EcsFargateContainerDefinition.

Current Behavior

No way to configure ephemeralStorage

Reproduction Steps

Create a new EcsJobDefinition(...) with new EcsFargateContainerDefinition(...) as container property

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.77.0 (build 06a0b19)

Framework Version

No response

Node.js Version

v16.13.0

OS

MacOS

Language

Typescript

Language Version

No response

Other information

No response
@gael-ft gael-ft added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 2, 2023
@github-actions github-actions bot added the @aws-cdk/aws-batch Related to AWS Batch label May 2, 2023
@pahud
Copy link
Contributor

pahud commented May 2, 2023

We probably can add it in EcsContainerDefinitionProps. Are you interested to submit a PR for that?

@pahud pahud added good first issue Related to contributions. See CONTRIBUTING.md p2 feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 2, 2023
@sumupitchayan sumupitchayan mentioned this issue May 2, 2023
Merged
@daschaa daschaa mentioned this issue May 2, 2023
Closed
@kaizencc
Copy link
Contributor

kaizencc commented May 2, 2023

@sumupitchayan @daschaa i mean it looks like you both created a PR for this issue at the exact same time. But maybe Sumu was first by minutes

@daschaa
Copy link
Contributor

daschaa commented May 3, 2023

@kaizencc Thanks for notifying. I'll close mine. 👍🏼

@mergify mergify bot closed this as completed in #25399 Jun 20, 2023
mergify bot pushed a commit that referenced this issue Jun 20, 2023
@sumupitchayan
feat(batch): ephemeralStorage property on job definitions (#25399)
a8768f4 
Closes #25393.

Adds missing `ephemeralStorage` property to `EcsFargateContainerDefinition` and `EcsFargateContainerDefinitionProps` along with a unit test.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-batch Related to AWS Batch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(batch): ephemeralStorage property on job definitions aws/aws-cdk
(batch): adds ephemeral storage property to EcsFargateContainerDefinition daschaa/aws-cdk
4 participants
@pahud @gael-ft @kaizencc @daschaa