feat(integ-runner): support --language presets for JavaScript, TypeScript, Python and Go
#22058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mrgrain
added
the
pr-linter/exempt-integ-test
|
@Mergifyio update |
✅ Branch has been successfully updated |
mrgrain
force-pushed
the
feat/integ-runner-ts
branch
2 times, most recently
from
2b3d688 to
be513c7
Compare
mrgrain
changed the title
4 tasks
mrgrain
force-pushed
the
feat/integ-runner-ts
branch
from
be513c7 to
6afa4c7
Compare
mrgrain
force-pushed
the
feat/integ-runner-ts
branch
2 times, most recently
from
b48d2fa to
e18a78b
Compare
mrgrain
changed the title
--language presets in integ-runner
mrgrain
changed the title
--language presets in integ-runner--language presets
mrgrain
force-pushed
the
feat/integ-runner-ts
branch
2 times, most recently
from
e90f498 to
47e1534
Compare
mrgrain
force-pushed
the
feat/integ-runner-ts
branch
from
47e1534 to
0601279
Compare
mrgrain
removed
the
pr-linter/exempt-integ-test
aws-cdk-automation
previously requested changes
Dec 15, 2022
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
mrgrain
force-pushed
the
feat/integ-runner-ts
branch
from
18364d3 to
0b6d427
Compare
|
Replaces #22927 |
mrgrain
force-pushed
the
feat/integ-runner-ts
branch
2 times, most recently
from
6af5c14 to
3a6057c
Compare
|
Unsupported languages du to lack of testing {
// works but it's a bit ugly to need to have a project per test case - is there a better solution?
csharp: ['dotnet run --project {filePath}', ['^Integ.*\\.csproj$']],
fsharp: ['dotnet run --project {filePath}', ['^Integ.*\\.fsproj$']],
// untested, but should be working
go: ['go mod download && go run {filePath}', ['^integ_.*\\.go$']],
// this doesn't work. See previous PR attempts for ideas
java: ['mvn -e -q compile exec:java', ['^Integ.*\\.java$']],
} |
mrgrain
force-pushed
the
feat/integ-runner-ts
branch
2 times, most recently
from
0a745b2 to
f40bd8f
Compare
mrgrain
force-pushed
the
feat/integ-runner-ts
branch
from
d3cb979 to
f40bd8f
Compare
corymhall
approved these changes
Jan 5, 2023
Comment on lines
+100
to
+108
| test('cannot use --test-regex by itself with more than one language preset', async () => { | ||
| await expect(() => main([ | ||
| '--list', | ||
| '--directory=test/test-data', | ||
| '--language=javascript', | ||
| '--language=typescript', | ||
| '--test-regex="^xxxxx\.integ-test[12]\.js$"', | ||
| ])).rejects.toThrowError('Only a single "--language" can be used with "--test-regex". Alternatively provide both "--app" and "--test-regex" to fully customize the configuration.'); | ||
| }); |
There was a problem hiding this comment.
If I'm reading everything correctly you can run it for multiple languages if you
just use the defaults, but if you want to customize anything you can only run it
for a single language? Is that right?
There was a problem hiding this comment.
Yes that's right. It's because we only have a single pair of --app and --test-regex. A possible future extension would be to allow configuring the presets or support passing in a map of app -> test-regex.
In the meantime, if both is needed, users can always run integ-runner multiple times, e.g.:
integ-runner --language typescript
integ-runner --language python --app="python3.2"
integ-runner --language go --test-regex=".*\.integ\.go"| @@ -0,0 +1,17 @@ | |||
| import aws_cdk as cdk | |||
mrgrain
force-pushed
the
feat/integ-runner-ts
branch
from
6a39e0a to
5ea37fc
Compare
mrgrain
changed the title
--language presets--language presets for JavaScript, TypeScript, Python and Go
mrgrain
added
pr/do-not-merge
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was already possible to run tests in any language by providing
--appand--test-regexdirectly.This change introduces the concept of language presets that can be selected.
By default all supported languages will be detected.
Users can run integration tests for multiple languages at the same time, using the default preset configuration.
To further customize anything, only a single language can be selected. However it's always possible to call the
integ-runnermultiple times:Resolves part of #21169
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license