Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(redshift-alpha): reboot Clusters for Parameter updates #22009

Closed
1 of 2 tasks
dontirun opened this issue Sep 12, 2022 · 3 comments · Fixed by #22063
Closed
1 of 2 tasks

(redshift-alpha): reboot Clusters for Parameter updates #22009

dontirun opened this issue Sep 12, 2022 · 3 comments · Fixed by #22063
Assignees
@comcalvi
Labels
@aws-cdk/aws-redshift Related to Amazon Redshift effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@dontirun
Copy link
Contributor

Describe the feature

Add an optional rebootForParameterChanges property to Redshift Clusters that reboots the cluster when there are changes to the Parameter group

Use Case

In most cases existing Clusters must be rebooted to apply parameter changes. It would be nice to automatically reboot the Cluster instead of having to manually do it through the CLI or console

Proposed Solution

  1. Add an optional rebootForParameterChanges property
  2. Create a Trigger and a Custom Resource Singleton Lambda to reboot the cluster if the associated Parameter Group changes
  3. The Lambda function only performs actions for Custom Resource On Create and On Update actions
  4. The Lambda function checks the parameterApplyStatus of the Parameter Group
    • If the Status is in-sync do nothing
    • If the Status is applying wait and recheck
    • If the Status is pending-reboot reboot the cluster

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

N/A

Environment details (OS name and version, etc.)

N/A
@dontirun dontirun added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 12, 2022
@github-actions github-actions bot added the @aws-cdk/aws-redshift Related to Amazon Redshift label Sep 12, 2022
@peterwoodworth peterwoodworth added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Sep 12, 2022
@peterwoodworth
Copy link
Contributor

Thanks for the request @dontirun, this is a great feature request that I think we should have!

We accept contributions - Check out our contributing guide if you're interested - there's a low chance the team will be able to address this soon but we'd be happy to review a PR 🙂

@dontirun dontirun mentioned this issue Sep 15, 2022
Merged
4 tasks
@dontirun
Copy link
Contributor Author

Having some trouble in the PR for the integration snapshots. The codebuild build is failing due to mismatched asset hashes on the new snapshot, but both locally and on a fresh gitpod it's verifying properly

❯ yarn integ-runner

Verifying integration test snapshots...

  UNCHANGED  integ.cluster-loggingbucket 0.931s
  UNCHANGED  integ.cluster-elasticip 0.935s
  UNCHANGED  integ.cluster-reboot 0.998s
  UNCHANGED  integ.database 10.763s

Snapshot Results: 

Tests:    4 passed, 4 total
✨  Done in 11.31s.

@mergify mergify bot closed this as completed in #22063 Feb 17, 2023
mergify bot pushed a commit that referenced this issue Feb 17, 2023
@dontirun
feat(redshift): optionally reboot Clusters to apply parameter changes (…
f61d950 
…#22063)

Closes #22009

Currently waiting on #22055  and #22059 for the assertions in the integration test to successfully run

----

### All Submissions:

* [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [X] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [X] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comcalvi comcalvi

Labels
@aws-cdk/aws-redshift Related to Amazon Redshift effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(redshift): optionally reboot Clusters to apply parameter changes dontirun/aws-cdk
3 participants
@dontirun @peterwoodworth @comcalvi