Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(iot): TopicRule action for CloudWatch alarms in AWS IoT #17705

Closed
2 tasks
yamatatsu opened this issue Nov 25, 2021 · 4 comments · Fixed by #18021
Closed
2 tasks

(iot): TopicRule action for CloudWatch alarms in AWS IoT #17705

yamatatsu opened this issue Nov 25, 2021 · 4 comments · Fixed by #18021
Labels
@aws-cdk/aws-iot Related to AWS IoT effort/small Small work item – less than a day of effort feature/service-integration Add functionality to an L2 construct to enable easier integration with another service feature-request A feature should be added or improved. p2

Comments

@yamatatsu
Copy link
Contributor

Description

The CDK has no support to put CloudWatch alarm status via AWS IoT Rule.

Use Case

Adding the action that puts CloudWatch alarm status to AWS IoT topic rule.

Proposed Solution

Implementing action class.

Probably, following PRs help coding.

Other information

Follofing documentation will be help.

It will be good first issue for learning implement feature in CDK!

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@yamatatsu yamatatsu added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 25, 2021
@github-actions github-actions bot added the @aws-cdk/aws-iot Related to AWS IoT label Nov 25, 2021
@peterwoodworth peterwoodworth added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 26, 2021
@peterwoodworth peterwoodworth added the feature/service-integration Add functionality to an L2 construct to enable easier integration with another service label Nov 26, 2021
@peterwoodworth
Copy link
Contributor

Thanks for the feature requests! Hopefully with these up, people will be able to chip down on adding these actions

@jerry-shao
Copy link
Member

I would like to implement this :D

@jerry-shao jerry-shao mentioned this issue Dec 14, 2021
Merged
@jerry-shao
Copy link
Member

PR: #18021

@mergify mergify bot closed this as completed in #18021 Dec 22, 2021
mergify bot pushed a commit that referenced this issue Dec 22, 2021
@jerry-shao
feat(iot): add Action to set a CloudWatch alarm (#18021)
de2369c 
Adding IoT Rule action for CloudWatch alarm.

Fixes #17705

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@jerry-shao @TikiTDO
feat(iot): add Action to set a CloudWatch alarm (aws#18021)
aab7c27 
Adding IoT Rule action for CloudWatch alarm.

Fixes aws#17705

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-iot Related to AWS IoT effort/small Small work item – less than a day of effort feature/service-integration Add functionality to an L2 construct to enable easier integration with another service feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(iot): add Action to set a CloudWatch alarm jerry-shao/aws-cdk
4 participants
@skinny85 @jerry-shao @yamatatsu @peterwoodworth