Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(apigatewayv2): support for mock integration type #15008

Closed
2 tasks done
lyraddigital opened this issue Jun 7, 2021 · 2 comments · Fixed by #18129
Closed
2 tasks done

(apigatewayv2): support for mock integration type #15008

lyraddigital opened this issue Jun 7, 2021 · 2 comments · Fixed by #18129
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@lyraddigital
Copy link

Currently in the @aws-cdk/aws-apigatewayv2 library only one WebSocketIntegrationType is supported. The AWS_PROXY integration type. The @aws-cdk/aws-apigatewayv2-integrations also only supports the LambdaWebSocketIntegration class to help connect a particular route to a Lambda function.

However when I create a Websocket API in the AWS console, there is support for HTTP, Mock, AWS Service and VPC Link.

I have created a simple Websocket API that does not require the client to communicate to the server. Only the server to communicate to the client. Therefore my $default route just has a simple MOCK integration, which works for my scenario.

Can we please add the other integrations type into this library? I am happy to assist if this is not already in progress. Just let me know.

Use Case

The reason for this requirement is because I'm using API Gateway to create a web socket server that talks to both a Twitch Bot and a React.js application which is hosted on my local machine and runs inside of OBS. Basically this is a requirement for a Twitch app I am creating. I could try another option (EC2 / ECS), AWS AppSync or event IOT, but in my research I believe using API Gateway and Lambda is the cheapest option.

Proposed Solution

Not much to propose. Just make it work similar to how the UI works now.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@lyraddigital lyraddigital added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 7, 2021
@github-actions github-actions bot added the @aws-cdk/aws-apigateway Related to Amazon API Gateway label Jun 7, 2021
@nija-at nija-at changed the title (apigateway): support for $default MOCK Integration Type (apigatewayv2): support for mock integration type Jun 21, 2021
@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label Jun 21, 2021
@nija-at nija-at added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 and removed @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 needs-triage This issue or PR still needs to be triaged. labels Jun 21, 2021
@nija-at nija-at removed their assignment Jul 19, 2021
@austinatchley
Copy link
Contributor

I'd like to take a stab at this one. This will be my first issue so I'm working through CONTRIBUTING.md and other docs first and hopefully I'll get to this in the next few days

The scope outlined in the title conflicts a bit with that of the description. I think I will proceed with only implementing the mock integration type for this issue, and we can open other issues for the other integration types as needed

Also curious as to why this was given the indicator for This feature might incur a breaking change. AFAIK no existing functionality will be affected

@mergify mergify bot closed this as completed in #18129 Jan 12, 2022
mergify bot pushed a commit that referenced this issue Jan 12, 2022
resolves  #15008

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
resolves  aws#15008

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants