Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-lambda-python] runtime should not be optional #10248

Closed
richardhboyd opened this issue Sep 8, 2020 · 2 comments · Fixed by #18143
Closed

[aws-lambda-python] runtime should not be optional #10248

richardhboyd opened this issue Sep 8, 2020 · 2 comments · Fixed by #18143
Labels
@aws-cdk/aws-lambda-python bug This issue is a bug. effort/small Small work item – less than a day of effort p1

Comments

@richardhboyd
Copy link
Contributor

❓ General Issue

By defaulting to Python3.7, we are guaranteeing that a breaking change will happen in the next few years when Python3.7 is EOL'd. While some breaking changes are unavoidable, we shouldn't be forcing our customers into one.

https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-lambda-python/lib/function.ts#L61
@richardhboyd richardhboyd added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Sep 8, 2020
@eladb eladb removed their assignment Feb 25, 2021
@NGL321 NGL321 self-assigned this May 17, 2021
@NGL321 NGL321 removed the needs-triage This issue or PR still needs to be triaged. label Jul 23, 2021
@NGL321 NGL321 removed their assignment Sep 20, 2021
@peterwoodworth peterwoodworth mentioned this issue Dec 22, 2021
Merged
@peterwoodworth peterwoodworth added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 and removed guidance Question that needs advice or information. labels Dec 22, 2021
@peterwoodworth
Copy link
Contributor

Sorry no one has responded to this yet @richardhboyd, I've created a PR to fix this.

@corymhall feel free to close these out if this is something we don't want to fix

@mergify mergify bot closed this as completed in #18143 Dec 23, 2021
mergify bot pushed a commit that referenced this issue Dec 23, 2021
@peterwoodworth
fix(lambda-python): runtime is now required (#18143)
98f1bb1 
BREAKING CHANGE: Runtime is now required for `LambdaPython`

fixes #10248

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@setu4993 setu4993 mentioned this issue Dec 29, 2021
Merged
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@peterwoodworth @TikiTDO
fix(lambda-python): runtime is now required (aws#18143)
f8b9309 
BREAKING CHANGE: Runtime is now required for `LambdaPython`

fixes aws#10248

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-lambda-python bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lambda-python): runtime is now required aws/aws-cdk
4 participants
@eladb @NGL321 @peterwoodworth @richardhboyd