fix(lambda-go): path with space breaks go build (#28554)

Output path with space breaks go build Solution: quoting `go build` output path Closes #28555 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws · Jan 3, 2024 · a8a639e · a8a639e
1 parent 669e6ff
commit a8a639e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/@aws-cdk/aws-lambda-go-alpha/lib/bundling.ts b/packages/@aws-cdk/aws-lambda-go-alpha/lib/bundling.ts
@@ -209,7 +209,7 @@ export class Bundling implements cdk.BundlingOptions {
     const goBuildCommand: string = [
       'go', 'build',
       hasVendor ? '-mod=vendor': '',
-      '-o', `${pathJoin(outputDir, 'bootstrap')}`,
+      '-o', `"${pathJoin(outputDir, 'bootstrap')}"`,
       `${this.props.goBuildFlags ? this.props.goBuildFlags.join(' ') : ''}`,
       `${this.relativeEntryPath.replace(/\\/g, '/')}`,
     ].filter(c => !!c).join(' ');

diff --git a/packages/@aws-cdk/aws-lambda-go-alpha/test/bundling.test.ts b/packages/@aws-cdk/aws-lambda-go-alpha/test/bundling.test.ts
@@ -53,7 +53,7 @@ test('bundling', () => {
       command: [
         'bash', '-c',
         [
-          'go build -o /asset-output/bootstrap ./cmd/api',
+          'go build -o "/asset-output/bootstrap" ./cmd/api',
         ].join(' && '),
       ],
     }),
@@ -81,7 +81,7 @@ test('bundling with file as entry', () => {
       command: [
         'bash', '-c',
         [
-          'go build -o /asset-output/bootstrap ./main.go',
+          'go build -o "/asset-output/bootstrap" ./main.go',
         ].join(' && '),
       ],
     }),
@@ -102,7 +102,7 @@ test('bundling with file in subdirectory as entry', () => {
       command: [
         'bash', '-c',
         [
-          'go build -o /asset-output/bootstrap ./cmd/api/main.go',
+          'go build -o "/asset-output/bootstrap" ./cmd/api/main.go',
         ].join(' && '),
       ],
     }),
@@ -123,7 +123,7 @@ test('bundling with file other than main.go in subdirectory as entry', () => {
       command: [
         'bash', '-c',
         [
-          'go build -o /asset-output/bootstrap ./cmd/api/api.go',
+          'go build -o "/asset-output/bootstrap" ./cmd/api/api.go',
         ].join(' && '),
       ],
     }),
@@ -265,7 +265,7 @@ test('Go build flags can be passed', () => {
       command: [
         'bash', '-c',
         [
-          'go build -o /asset-output/bootstrap -ldflags "-s -w" ./cmd/api',
+          'go build -o "/asset-output/bootstrap" -ldflags "-s -w" ./cmd/api',
         ].join(' && '),
       ],
     }),
@@ -297,7 +297,7 @@ test('AssetHashType can be specified', () => {
       command: [
         'bash', '-c',
         [
-          'go build -o /asset-output/bootstrap ./cmd/api',
+          'go build -o "/asset-output/bootstrap" ./cmd/api',
         ].join(' && '),
       ],
     }),