Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Swift 4.2 and fix SwiftLint warnings #5

Merged
merged 2 commits into from
Nov 23, 2018
Merged

Update to Swift 4.2 and fix SwiftLint warnings #5

merged 2 commits into from
Nov 23, 2018

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Nov 22, 2018

No description provided.

@AvdLee AvdLee self-assigned this Nov 22, 2018
@AvdLee AvdLee requested a review from renssies November 22, 2018 15:34
@renssies
Copy link
Contributor

@AvdLee could you also fix the Travis.yml with Xcode 10? That's the reason CI breaks

@AvdLee
Copy link
Contributor Author

AvdLee commented Nov 23, 2018

Good call, done!

@AvdLee AvdLee merged commit 4c68a07 into master Nov 23, 2018
@AvdLee AvdLee deleted the feature/swift-4-2-update branch November 23, 2018 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renssies renssies renssies approved these changes

Assignees

@AvdLee AvdLee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AvdLee @renssies