Added inlineSources: true to tsconfig.json #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋
TLDR
I'm hoping to turn on
inlineSources
in your tsconfig.json file so that webpack stops complaining.Explanation
I'm working on the gadget-inc/js-clients packages and I'm trying to get rid of webpack source map warnings from being emitted when someone uses our react client in a create-react-app v5 project.
I was able to fix the warnings with this (soon to be merged) PR, but our clients use your package under the hood, and it looks like your package also emits warnings.
I figured out that webpack is complaining because your source maps are referencing files in your
src
directory but you don't include yoursrc
directory when you publish to npm.To fix this, you could do one of the following:
src
directory when publishing to npminlineSources
in your tsconfig.jsonI think the
inlineSources
option is the easiest one... but it's up to you 😄