Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appveyor problem with python3.5 #294

Closed
bsipocz opened this issue Nov 26, 2015 · 5 comments
Closed

appveyor problem with python3.5 #294

bsipocz opened this issue Nov 26, 2015 · 5 comments

Comments

@bsipocz
Copy link
Member

bsipocz commented Nov 26, 2015

It may be trivial for someone with windows experience (@mwcraig or @astrofrog), but I run out of ideas, so leave it here in an issue before merging #292 without adding py3.5 to appveyor.

https://ci.appveyor.com/project/Astropy/photutils/build/1.0.153/job/xs87di6qchlworuf
https://ci.appveyor.com/project/Astropy/photutils/build/1.0.154/job/vt999t9pemy8dcqq

bsipocz added a commit to bsipocz/photutils that referenced this issue Nov 26, 2015
@mwcraig
Copy link
Member

mwcraig commented Nov 28, 2015

The problem (I think) is that default compiler on Windows changed in python 3.5 but the appveyor setup scripts (%CMD_IN_ENV% in particular) configures the compiler to that used in python 3 prior to 3.5.

Will end up resolving this over the weekend for the affiliate builder, I hope, and port the change here (or to the new CI helper package).

@astrofrog
Copy link
Member

@mwcraig - it would be great to fix this in the ci-helpers if this applies to all packages with compiled code

@bsipocz
Copy link
Member Author

bsipocz commented Nov 29, 2015

@astrofrog - And also we have to come up with something to reproduce this error in ci-helpers, as it seems that the py3.5 builds pass there.

@mwcraig
Copy link
Member

mwcraig commented Nov 30, 2015

@bsipocz -- actually, I don't think it is necessary to add a test. Changing the default compiler seems to happen only every ~5+ years, and my understanding is that in the future it will not be necessary to match compiler versions as is necessary now, so the current config should, in principle, be good for a long while. I don't understand all of it, but the current situation is discussed here: http://stevedower.id.au/blog/building-for-python-3-5-part-two/

@bsipocz
Copy link
Member Author

bsipocz commented Dec 17, 2015

Fixed in #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants